Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): add lookup task by name in httpmw.TaskParam#20647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 10 commits intomainfromcj/task-link-by-name
Nov 5, 2025

Conversation

@johnstcn
Copy link
Member

  • Adds aGetTaskByOwnerIDAndName query
  • Updateshttpmw.TaskParam to fall back to task name if no task by UUID found.

Note: I originally added a tertiary fallback to lookup by workspace name but elected to remove it for simplicity.

Mostly generated by Claude with manual refactoring.

@johnstcnjohnstcn self-assigned thisNov 3, 2025
@johnstcnjohnstcn marked this pull request as ready for reviewNovember 3, 2025 11:24
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With this change we can remove the custom code in codersdk (used by CLI/toolsdk).

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor nits/suggestions but otherwise looks pretty good. I see one of the previous comments are not addressed yet but once fixed I think this is good to go 👍🏻

@johnstcnjohnstcn changed the titlefeat(coderd): support looking up task by name in httpmw.TaskParamfeat(coderd): add lookup task by name in httpmw.TaskParamNov 5, 2025
@johnstcnjohnstcn merged commit34f6e72 intomainNov 5, 2025
30 checks passed
@johnstcnjohnstcn deleted the cj/task-link-by-name branchNovember 5, 2025 14:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp