Nov 3, 2025 · Oct 30, 2025 · Nov 3, 2025 · Oct 30, 2025
diff --git a/coderd/database/check_constraint.go b/coderd/database/check_constraint.go
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/.../database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.down.sql b/.../database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.down.sql
 -- WARNING: Restoring this constraint after running a newer version of coderd
 -- and using tasks is bound to break this constraint.
 ALTER TABLE workspace_builds
 ADD CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required CHECK (((((has_ai_task IS NULL) OR (has_ai_task = false)) AND (ai_task_sidebar_app_id IS NULL)) OR ((has_ai_task = true) AND (ai_task_sidebar_app_id IS NOT NULL))));
diff --git a/...rd/database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.up.sql b/...rd/database/migrations/000394_drop_workspace_build_ai_task_sidebar_app_id_required.up.sql
 -- We no longer need to enforce this constraint as tasks have their own data
 -- model.
 ALTER TABLE workspace_builds
 DROP CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required;
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
 }
 }

 var taskAppID uuid.NullUUID
 var taskAgentID uuid.NullUUID
 var hasAITask bool
 var warnUnknownTaskAppID bool
 var (
 hasAITask    bool
 unknownAppID string
 taskAppID    uuid.NullUUID
 taskAgentID  uuid.NullUUID
 )
 if tasks := jobType.WorkspaceBuild.GetAiTasks(); len(tasks) > 0 {
 hasAITask = true
 task := tasks[0]
 }

 if !slices.Contains(appIDs, appID) {
 warnUnknownTaskAppID = true
 }

 id, err := uuid.Parse(appID)
 if err != nil {
 return xerrors.Errorf("parse app id: %w", err)
 }

 taskAppID = uuid.NullUUID{UUID: id, Valid: true}

 agentID, ok := agentIDByAppID[appID]
 taskAgentID = uuid.NullUUID{UUID: agentID, Valid: ok}
 }

 // This is a hacky workaround for the issue with tasks 'disappearing' on stop:
 // reuse has_ai_task and sidebar_app_id from the previous build.
 // This workaround should be removed as soon as possible.
 if workspaceBuild.Transition == database.WorkspaceTransitionStop && workspaceBuild.BuildNumber > 1 {
 if prevBuild, err := s.Database.GetWorkspaceBuildByWorkspaceIDAndBuildNumber(ctx, database.GetWorkspaceBuildByWorkspaceIDAndBuildNumberParams{
 WorkspaceID: workspaceBuild.WorkspaceID,
 BuildNumber: workspaceBuild.BuildNumber - 1,
 }); err == nil {
 hasAITask = prevBuild.HasAITask.Bool
 taskAppID = prevBuild.AITaskSidebarAppID
 warnUnknownTaskAppID = false
 s.Logger.Debug(ctx, "task workaround: reused has_ai_task and app_id from previous build to keep track of task",
 slog.F("job_id", job.ID.String()),
 slog.F("build_number", prevBuild.BuildNumber),
 slog.F("workspace_id", workspace.ID),
 slog.F("workspace_build_id", workspaceBuild.ID),
 slog.F("transition", string(workspaceBuild.Transition)),
 slog.F("sidebar_app_id", taskAppID.UUID),
 slog.F("has_ai_task", hasAITask),
 )
 unknownAppID = appID
 hasAITask = false
 } else {
 s.Logger.Error(ctx, "task workaround: tracking via has_ai_task and app_id from previous build failed",
 slog.Error(err),
 slog.F("job_id", job.ID.String()),
 slog.F("workspace_id", workspace.ID),
 slog.F("workspace_build_id", workspaceBuild.ID),
 slog.F("transition", string(workspaceBuild.Transition)),
 )
 // Only parse for valid app and agent to avoid fk violation.
 id, err := uuid.Parse(appID)
 if err != nil {
 return xerrors.Errorf("parse app id: %w", err)
 }
 taskAppID = uuid.NullUUID{UUID: id, Valid: true}

 agentID, ok := agentIDByAppID[appID]
 taskAgentID = uuid.NullUUID{UUID: agentID, Valid: ok}
 }
 }

 ifwarnUnknownTaskAppID {
 ifunknownAppID != "" && workspaceBuild.Transition == database.WorkspaceTransitionStart {
 // Ref: https://github.com/coder/coder/issues/18776
 // This can happen for a number of reasons:
 // 1. Misconfigured template
 // 2. Count=0 on the agent due to stop transition, meaning the associated coder_app was not inserted.
 // Failing the build at this point is not ideal, so log a warning instead.
 s.Logger.Warn(ctx, "unknown ai_task_app_id",
 slog.F("ai_task_app_id",taskAppID.UUID.String()),
 slog.F("ai_task_app_id",unknownAppID),
 slog.F("job_id", job.ID.String()),
 slog.F("workspace_id", workspace.ID),
 slog.F("workspace_build_id", workspaceBuild.ID),
 slog.F("transition", string(workspaceBuild.Transition)),
 )
 }
 // Important: reset hasAITask and sidebarAppID so that we don't run into a fk constraint violation.
 hasAITask = false
 taskAppID = uuid.NullUUID{}
 }

 if hasAITask && workspaceBuild.Transition == database.WorkspaceTransitionStart {
 }
 }

 hasExternalAgent := false
 for _, resource := range jobType.WorkspaceBuild.Resources {
 if resource.Type == "coder_external_agent" {
 hasExternalAgent = true
 break
 }
 }

 if task, err := db.GetTaskByWorkspaceID(ctx, workspace.ID); err == nil {
 // Irrespective of whether the agent or sidebar app is present,
 // perform the upsert to ensure a link between the task and
 return xerrors.Errorf("get task by workspace id: %w", err)
 }

 // Regardless of whether there is an AI task or not, update the field to indicate one way or the other since it
 // always defaults to nil. ONLY if has_ai_task=true MUST ai_task_sidebar_app_id be set.
 _, hasExternalAgent := slice.Find(jobType.WorkspaceBuild.Resources, func(resource *sdkproto.Resource) bool {
 return resource.Type == "coder_external_agent"
 })
 if err := db.UpdateWorkspaceBuildFlagsByID(ctx, database.UpdateWorkspaceBuildFlagsByIDParams{
 ID: workspaceBuild.ID,
 HasAITask: sql.NullBool{
 Bool:  hasAITask,
 Valid: true,
 },
 SidebarAppID: taskAppID, // SidebarAppID is not required, but kept for API backwards compatibility.
 HasExternalAgent: sql.NullBool{
 Bool:  hasExternalAgent,
 Valid: true,
 },
 SidebarAppID: taskAppID,
 UpdatedAt:    now,
 UpdatedAt: now,
 }); err != nil {
 return xerrors.Errorf("update workspace build ai tasks and external agent flag: %w", err)
 }
diff --git a/coderd/provisionerdserver/provisionerdserver_test.go b/coderd/provisionerdserver/provisionerdserver_test.go
 input            *proto.CompletedJob_WorkspaceBuild
 isTask           bool
 expectTaskStatus database.TaskStatus
 expectAppID      uuid.NullUUID
 expectHasAiTask  bool
 expectUsageEvent bool
 }

 sidebarAppID := uuid.NewString()
 sidebarAppID := uuid.New()
 for _, tc := range []testcase{
 {
 name:       "has_ai_task is false by default",
 {
 name:       "has_ai_task is set to true",
 transition: database.WorkspaceTransitionStart,
 input: &proto.CompletedJob_WorkspaceBuild{
 AiTasks: []*sdkproto.AITask{
 {
 Id:    uuid.NewString(),
 AppId: sidebarAppID.String(),
 },
 },
 Resources: []*sdkproto.Resource{
 {
 Agents: []*sdkproto.Agent{
 {
 Id:   uuid.NewString(),
 Name: "a",
 Apps: []*sdkproto.App{
 {
 Id:   sidebarAppID.String(),
 Slug: "test-app",
 },
 },
 },
 },
 },
 },
 },
 isTask:           true,
 expectTaskStatus: database.TaskStatusInitializing,
 expectAppID:      uuid.NullUUID{UUID: sidebarAppID, Valid: true},
 expectHasAiTask:  true,
 expectUsageEvent: true,
 },
 {
 name:       "has_ai_task is set to true, with sidebar app id",
 transition: database.WorkspaceTransitionStart,
 input: &proto.CompletedJob_WorkspaceBuild{
 AiTasks: []*sdkproto.AITask{
 {
 Id: uuid.NewString(),
 SidebarApp: &sdkproto.AITaskSidebarApp{
 Id: sidebarAppID,
 Id: sidebarAppID.String(),
 },
 },
 },
 Name: "a",
 Apps: []*sdkproto.App{
 {
 Id:   sidebarAppID,
 Id:   sidebarAppID.String(),
 Slug: "test-app",
 },
 },
 },
 isTask:           true,
 expectTaskStatus: database.TaskStatusInitializing,
 expectAppID:      uuid.NullUUID{UUID: sidebarAppID, Valid: true},
 expectHasAiTask:  true,
 expectUsageEvent: true,
 },
 AiTasks: []*sdkproto.AITask{
 {
 Id: uuid.NewString(),
 SidebarApp: &sdkproto.AITaskSidebarApp{
 // Non-existing app ID would previously trigger a FK violation.
 Id: uuid.NewString(),
 },
 // Non-existing app ID would previously trigger a FK violation.
 // Now it should just be ignored.
 AppId: sidebarAppID.String(),
 },
 },
 },
 input: &proto.CompletedJob_WorkspaceBuild{
 AiTasks: []*sdkproto.AITask{
 {
 Id: uuid.NewString(),
 SidebarApp: &sdkproto.AITaskSidebarApp{
 Id: sidebarAppID,
 },
 Id:    uuid.NewString(),
 AppId: sidebarAppID.String(),
 },
 },
 Resources: []*sdkproto.Resource{
 Name: "a",
 Apps: []*sdkproto.App{
 {
 Id:   sidebarAppID,
 Id:   sidebarAppID.String(),
 Slug: "test-app",
 },
 },
 },
 isTask:           true,
 expectTaskStatus: database.TaskStatusPaused,
 expectAppID:      uuid.NullUUID{UUID: sidebarAppID, Valid: true},
 expectHasAiTask:  true,
 expectUsageEvent: false,
 },
 },
 isTask:           true,
 expectTaskStatus: database.TaskStatusPaused,
 expectHasAiTask:true,
 expectHasAiTask:false, // We no longer inherit this from the previous build.
 expectUsageEvent: false,
 },
 } {
 require.True(t, build.HasAITask.Valid) // We ALWAYS expect a value to be set, therefore not nil, i.e. valid = true.
 require.Equal(t, tc.expectHasAiTask, build.HasAITask.Bool)

 task, err := db.GetTaskByID(ctx, genTask.ID)
 if tc.isTask {
 task, err := db.GetTaskByID(ctx, genTask.ID)
 require.NoError(t, err)
 require.Equal(t, tc.expectTaskStatus, task.Status)
 } else {
 require.Error(t, err)
 }

 if tc.expectHasAiTask && build.Transition != database.WorkspaceTransitionStop {
 require.Equal(t, sidebarAppID, build.AITaskSidebarAppID.UUID.String())
 }
 require.Equal(t, tc.expectAppID, task.WorkspaceAppID)
 require.Equal(t, tc.expectAppID, build.AITaskSidebarAppID)

 if tc.expectUsageEvent {
 // Check that a usage event was collected.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		-- WARNING: Restoring this constraint after running a newer version of coderd
		-- and using tasks is bound to break this constraint.
		ALTER TABLE workspace_builds
		ADD CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required CHECK (((((has_ai_task IS NULL) OR (has_ai_task = false)) AND (ai_task_sidebar_app_id IS NULL)) OR ((has_ai_task = true) AND (ai_task_sidebar_app_id IS NOT NULL))));
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		-- We no longer need to enforce this constraint as tasks have their own data
		-- model.
		ALTER TABLE workspace_builds
		DROP CONSTRAINT workspace_builds_ai_task_sidebar_app_id_required;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2006,10 +2006,12 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
		}
		}

		var taskAppID uuid.NullUUID
		var taskAgentID uuid.NullUUID
		var hasAITask bool
		var warnUnknownTaskAppID bool
		var (
		hasAITask bool
		unknownAppID string
		taskAppID uuid.NullUUID
		taskAgentID uuid.NullUUID
		)
		if tasks := jobType.WorkspaceBuild.GetAiTasks(); len(tasks) > 0 {
		hasAITask = true
		task := tasks[0]
Expand All		@@ -2026,59 +2028,29 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
		}

		if !slices.Contains(appIDs, appID) {
		warnUnknownTaskAppID = true
		}

		id, err := uuid.Parse(appID)
		if err != nil {
		return xerrors.Errorf("parse app id: %w", err)
		}

		taskAppID = uuid.NullUUID{UUID: id, Valid: true}

		agentID, ok := agentIDByAppID[appID]
		taskAgentID = uuid.NullUUID{UUID: agentID, Valid: ok}
		}

		// This is a hacky workaround for the issue with tasks 'disappearing' on stop:
		// reuse has_ai_task and sidebar_app_id from the previous build.
		// This workaround should be removed as soon as possible.
		if workspaceBuild.Transition == database.WorkspaceTransitionStop && workspaceBuild.BuildNumber > 1 {
		if prevBuild, err := s.Database.GetWorkspaceBuildByWorkspaceIDAndBuildNumber(ctx, database.GetWorkspaceBuildByWorkspaceIDAndBuildNumberParams{
		WorkspaceID: workspaceBuild.WorkspaceID,
		BuildNumber: workspaceBuild.BuildNumber - 1,
		}); err == nil {
		hasAITask = prevBuild.HasAITask.Bool
		taskAppID = prevBuild.AITaskSidebarAppID
		warnUnknownTaskAppID = false
		s.Logger.Debug(ctx, "task workaround: reused has_ai_task and app_id from previous build to keep track of task",
		slog.F("job_id", job.ID.String()),
		slog.F("build_number", prevBuild.BuildNumber),
		slog.F("workspace_id", workspace.ID),
		slog.F("workspace_build_id", workspaceBuild.ID),
		slog.F("transition", string(workspaceBuild.Transition)),
		slog.F("sidebar_app_id", taskAppID.UUID),
		slog.F("has_ai_task", hasAITask),
		)
Comment on lines -2029 to -2062 Copy link Member johnstcnOct 30, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. ❤️
		unknownAppID = appID
		hasAITask = false
		} else {
		s.Logger.Error(ctx, "task workaround: tracking via has_ai_task and app_id from previous build failed",
		slog.Error(err),
		slog.F("job_id", job.ID.String()),
		slog.F("workspace_id", workspace.ID),
		slog.F("workspace_build_id", workspaceBuild.ID),
		slog.F("transition", string(workspaceBuild.Transition)),
		)
		// Only parse for valid app and agent to avoid fk violation.
		id, err := uuid.Parse(appID)
		if err != nil {
		return xerrors.Errorf("parse app id: %w", err)
johnstcn marked this conversation as resolved. Show resolvedHide resolved
		}
		taskAppID = uuid.NullUUID{UUID: id, Valid: true}

		agentID, ok := agentIDByAppID[appID]
		taskAgentID = uuid.NullUUID{UUID: agentID, Valid: ok}
		}
		}

		ifwarnUnknownTaskAppID {
		ifunknownAppID != "" && workspaceBuild.Transition == database.WorkspaceTransitionStart {
		// Ref: https://github.com/coder/coder/issues/18776
		// This can happen for a number of reasons:
		// 1. Misconfigured template
		// 2. Count=0 on the agent due to stop transition, meaning the associated coder_app was not inserted.
		// Failing the build at this point is not ideal, so log a warning instead.
		s.Logger.Warn(ctx, "unknown ai_task_app_id",
		slog.F("ai_task_app_id",taskAppID.UUID.String()),
		slog.F("ai_task_app_id",unknownAppID),
		slog.F("job_id", job.ID.String()),
		slog.F("workspace_id", workspace.ID),
		slog.F("workspace_build_id", workspaceBuild.ID),
Expand All		@@ -2105,9 +2077,6 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
		slog.F("transition", string(workspaceBuild.Transition)),
		)
		}
		// Important: reset hasAITask and sidebarAppID so that we don't run into a fk constraint violation.
		hasAITask = false
		taskAppID = uuid.NullUUID{}
		}

		if hasAITask && workspaceBuild.Transition == database.WorkspaceTransitionStart {
Expand All		@@ -2124,14 +2093,6 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
		}
		}

		hasExternalAgent := false
		for _, resource := range jobType.WorkspaceBuild.Resources {
		if resource.Type == "coder_external_agent" {
		hasExternalAgent = true
		break
		}
		}

		if task, err := db.GetTaskByWorkspaceID(ctx, workspace.ID); err == nil {
		// Irrespective of whether the agent or sidebar app is present,
		// perform the upsert to ensure a link between the task and
Expand All		@@ -2153,20 +2114,21 @@ func (s *server) completeWorkspaceBuildJob(ctx context.Context, job database.Pro
		return xerrors.Errorf("get task by workspace id: %w", err)
		}

		// Regardless of whether there is an AI task or not, update the field to indicate one way or the other since it
		// always defaults to nil. ONLY if has_ai_task=true MUST ai_task_sidebar_app_id be set.
		_, hasExternalAgent := slice.Find(jobType.WorkspaceBuild.Resources, func(resource *sdkproto.Resource) bool {
		return resource.Type == "coder_external_agent"
		})
		if err := db.UpdateWorkspaceBuildFlagsByID(ctx, database.UpdateWorkspaceBuildFlagsByIDParams{
		ID: workspaceBuild.ID,
		HasAITask: sql.NullBool{
		Bool: hasAITask,
		Valid: true,
		},
		SidebarAppID: taskAppID, // SidebarAppID is not required, but kept for API backwards compatibility.
		HasExternalAgent: sql.NullBool{
		Bool: hasExternalAgent,
		Valid: true,
		},
		SidebarAppID: taskAppID,
		UpdatedAt: now,
		UpdatedAt: now,
		}); err != nil {
		return xerrors.Errorf("update workspace build ai tasks and external agent flag: %w", err)
		}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2864,11 +2864,12 @@ func TestCompleteJob(t *testing.T) {
		input *proto.CompletedJob_WorkspaceBuild
		isTask bool
		expectTaskStatus database.TaskStatus
		expectAppID uuid.NullUUID
		expectHasAiTask bool
		expectUsageEvent bool
		}

		sidebarAppID := uuid.NewString()
		sidebarAppID := uuid.New()
		for _, tc := range []testcase{
		{
		name: "has_ai_task is false by default",
Expand All		@@ -2883,12 +2884,45 @@ func TestCompleteJob(t *testing.T) {
		{
		name: "has_ai_task is set to true",
		transition: database.WorkspaceTransitionStart,
		input: &proto.CompletedJob_WorkspaceBuild{
		AiTasks: []*sdkproto.AITask{
		{
		Id: uuid.NewString(),
		AppId: sidebarAppID.String(),
		},
		},
		Resources: []*sdkproto.Resource{
		{
		Agents: []*sdkproto.Agent{
		{
		Id: uuid.NewString(),
		Name: "a",
		Apps: []*sdkproto.App{
		{
		Id: sidebarAppID.String(),
		Slug: "test-app",
		},
		},
		},
		},
		},
		},
		},
		isTask: true,
		expectTaskStatus: database.TaskStatusInitializing,
		expectAppID: uuid.NullUUID{UUID: sidebarAppID, Valid: true},
		expectHasAiTask: true,
		expectUsageEvent: true,
		},
		{
		name: "has_ai_task is set to true, with sidebar app id",
		transition: database.WorkspaceTransitionStart,
		input: &proto.CompletedJob_WorkspaceBuild{
		AiTasks: []*sdkproto.AITask{
		{
		Id: uuid.NewString(),
		SidebarApp: &sdkproto.AITaskSidebarApp{
		Id: sidebarAppID,
		Id: sidebarAppID.String(),
		},
		},
		},
Expand All		@@ -2900,7 +2934,7 @@ func TestCompleteJob(t *testing.T) {
		Name: "a",
		Apps: []*sdkproto.App{
		{
		Id: sidebarAppID,
		Id: sidebarAppID.String(),
		Slug: "test-app",
		},
		},
Expand All		@@ -2911,6 +2945,7 @@ func TestCompleteJob(t *testing.T) {
		},
		isTask: true,
		expectTaskStatus: database.TaskStatusInitializing,
		expectAppID: uuid.NullUUID{UUID: sidebarAppID, Valid: true},
		expectHasAiTask: true,
		expectUsageEvent: true,
		},
Expand All		@@ -2922,10 +2957,9 @@ func TestCompleteJob(t *testing.T) {
		AiTasks: []*sdkproto.AITask{
		{
		Id: uuid.NewString(),
		SidebarApp: &sdkproto.AITaskSidebarApp{
		// Non-existing app ID would previously trigger a FK violation.
		Id: uuid.NewString(),
		},
		// Non-existing app ID would previously trigger a FK violation.
		// Now it should just be ignored.
		AppId: sidebarAppID.String(),
		},
		},
		},
Expand All		@@ -2940,10 +2974,8 @@ func TestCompleteJob(t *testing.T) {
		input: &proto.CompletedJob_WorkspaceBuild{
		AiTasks: []*sdkproto.AITask{
		{
		Id: uuid.NewString(),
		SidebarApp: &sdkproto.AITaskSidebarApp{
		Id: sidebarAppID,
		},
		Id: uuid.NewString(),
		AppId: sidebarAppID.String(),
		},
		},
		Resources: []*sdkproto.Resource{
Expand All		@@ -2954,7 +2986,7 @@ func TestCompleteJob(t *testing.T) {
		Name: "a",
		Apps: []*sdkproto.App{
		{
		Id: sidebarAppID,
		Id: sidebarAppID.String(),
		Slug: "test-app",
		},
		},
Expand All		@@ -2965,6 +2997,7 @@ func TestCompleteJob(t *testing.T) {
		},
		isTask: true,
		expectTaskStatus: database.TaskStatusPaused,
		expectAppID: uuid.NullUUID{UUID: sidebarAppID, Valid: true},
		expectHasAiTask: true,
		expectUsageEvent: false,
		},
Expand All		@@ -2978,7 +3011,7 @@ func TestCompleteJob(t *testing.T) {
		},
		isTask: true,
		expectTaskStatus: database.TaskStatusPaused,
		expectHasAiTask:true,
		expectHasAiTask:false, // We no longer inherit this from the previous build.
		expectUsageEvent: false,
		},
		} {
Expand DownExpand Up		@@ -3092,15 +3125,16 @@ func TestCompleteJob(t *testing.T) {
		require.True(t, build.HasAITask.Valid) // We ALWAYS expect a value to be set, therefore not nil, i.e. valid = true.
		require.Equal(t, tc.expectHasAiTask, build.HasAITask.Bool)

		task, err := db.GetTaskByID(ctx, genTask.ID)
		if tc.isTask {
		task, err := db.GetTaskByID(ctx, genTask.ID)
		require.NoError(t, err)
		require.Equal(t, tc.expectTaskStatus, task.Status)
		} else {
		require.Error(t, err)
		}

		if tc.expectHasAiTask && build.Transition != database.WorkspaceTransitionStop {
		require.Equal(t, sidebarAppID, build.AITaskSidebarAppID.UUID.String())
		}
		require.Equal(t, tc.expectAppID, task.WorkspaceAppID)
		require.Equal(t, tc.expectAppID, build.AITaskSidebarAppID)

		if tc.expectUsageEvent {
		// Check that a usage event was collected.
Expand Down