- Notifications
You must be signed in to change notification settings - Fork1.1k
refactor: use task data model for notifications#20590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
refactor: use task data model for notifications#20590
Conversation
Uh oh!
There was an error while loading.Please reload this page.
d379e17 to841cb33CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| AllowIDList: []AllowListElement{ | ||
| AllowIDList:append([]AllowListElement{ | ||
| {Type:ResourceWorkspace.Type,ID:params.WorkspaceID.String()}, | ||
| {Type:ResourceTemplate.Type,ID:params.TemplateID.String()}, | ||
| {Type:ResourceTemplate.Type,ID:params.VersionID.String()}, | ||
| {Type:ResourceUser.Type,ID:params.OwnerID.String()}, | ||
| }, | ||
| },extraAllowList...), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is nice and narrow 👍
Just for future info, you can also do this:{Type: ResourceTask.Type, ID: policy.WildcardSymbol},
To give it access to all tasks. I assume each workspace just has 1 task though. And being narrow is better 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep, tasks and workspaces are 1:1 currently. Good to know about the wildcard though, thanks. 👍🏻
7ae3fdc intomainUh oh!
There was an error while loading.Please reload this page.
Updatescoder/internal#973
Updatescoder/internal#974