- Notifications
You must be signed in to change notification settings - Fork1.1k
refactor!: remove TaskAppID from codersdk.WorkspaceBuild#20583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
48f0148 to25cba70CompareWe can instead use the new data model for this, there is no reason tohave it stored inside the workspace build. `TaskAppID` has not _yet_been shipped into a release. This would need cherry-picking if we wantedto go ahead with it.If we don't want to cherry-pick, we should instead mark the TaskAppID asdeprecated. This isn't ideal as it hasn't even been released yet.
25cba70 to7a97ebeComparemafredri approved these changesOct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me 👍🏻
| TemplateVersionPresetID*uuid.UUID`json:"template_version_preset_id" format:"uuid"` | ||
| HasAITask*bool`json:"has_ai_task,omitempty"` | ||
| // Deprecated: This field has been replaced with `TaskAppID` | ||
| // Deprecated: This field has been replaced with `Task.WorkspaceAppID` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
❤️
johnstcn approved these changesOct 30, 2025
d80b5fc intomain 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
cherry-pick/v2.28Needs to be cherry-picked to the 2.28 release branch release/breakingThis label is applied to PRs to detect breaking changes as part of the release process
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can instead use the new data model for this, there is no reason to have it stored inside the workspace build.
TaskAppIDhas notyet been shipped into a release. This would need cherry-picking if we wanted to go ahead with it.