- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add prebuild invalidation via last_invalidated_at timestamp#20582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mtojek wants to merge31 commits intomainChoose a base branch from17917-prebuilds-invalidation
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Implements new approach for prebuild invalidation as discussed in issue#17917.Instead of directly deleting workspaces, this sets a timestamp on presets,and the reconciler automatically marks prebuilds as expired and creates new ones.Implementation:- Add last_invalidated_at column to template_version_presets table- API endpoint: POST /templates/{template}/prebuilds/invalidate- Updates last_invalidated_at = NOW() for all active template version presets- filterExpiredWorkspaces checks if prebuild.created_at < preset.last_invalidated_at- Reconciler automatically deletes expired prebuilds and spawns fresh onesChanges:- Migration 000394: Add last_invalidated_at column- Query: UpdatePresetsLastInvalidatedAt sets timestamp on active presets- API: Returns count and list of invalidated preset names- Logic: filterExpiredWorkspaces prioritizes last_invalidated_at over TTL- SDK: InvalidateTemplatePrebuilds client method with structured responseBenefits:- Non-blocking: API doesn't wait for reconciler- Async: Reconciler handles actual deletion- Safe: template_version_presets is no longer write-onceUpdates#17917
04ba875 to6019903Compare- Use uuid.NullUUID{UUID: template.ID, Valid: true}- Use sql.NullTime{Time: dbtime.Now(), Valid: true}96249b9 to90b75e1CompareThis reverts commitf8a06c6.
Remove redundant subquery - template_version_id IN (...) AND template_version_id = (...)is unnecessary. Just check template_version_id = active_version_id directly.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implements prebuild invalidation by setting
last_invalidated_attimestamp on presets.The reconciler automatically marks prebuilds as expired if
prebuild.created_at < preset.last_invalidated_atand spawns fresh ones.API:
POST /templates/{template}/prebuilds/invalidateResponse:
{"invalidated_presets": ["preset-1","preset-2","preset-3"]}Updates#17917