Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: delete related task when deleting workspace#20567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 7 commits intomainfromcj/task-deleted-workspace
Oct 30, 2025

Conversation

@johnstcn
Copy link
Member

@johnstcnjohnstcn commentedOct 29, 2025•
edited
Loading

  • Instead of prompting the user to start a deleted workspace (which is silly), prompt them to create a new task instead.
Screenshot 2025-10-30 at 13 04 00
  • Adds a warning dialog when deleting a workspace
Screenshot 2025-10-30 at 13 04 06
  • Updates provisionerdserver to delete the related task if a workspace is related to a task

Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Something looks a bit off with this 😅

SCR-20251029-ssoa

@johnstcn
Copy link
MemberAuthor

johnstcn commentedOct 29, 2025•
edited
Loading

Something looks a bit off with this 😅

SCR-20251029-ssoa

Yeah I need to style it a bit 🙃 Alternative is to delete the task when deleting the workspace, which I think is a better option.

EDIT: actually, we still may need this regardless.

DanielleMaywood reacted with thumbs up emoji

@johnstcnjohnstcn marked this pull request as draftOctober 29, 2025 21:47
@johnstcnjohnstcn changed the titlefix(site): handle deleted task workspace in TaskPagefix: improve handling of deleted task workspacesOct 29, 2025
@johnstcnjohnstcn marked this pull request as ready for reviewOctober 29, 2025 22:11
@johnstcnjohnstcn changed the titlefix: improve handling of deleted task workspacesfix: delete related task when deleting workspaceOct 29, 2025
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

storybook ok 👍

@johnstcnjohnstcn merged commit73dedcc intomainOct 30, 2025
35 checks passed
@johnstcnjohnstcn deleted the cj/task-deleted-workspace branchOctober 30, 2025 10:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 30, 2025
@johnstcn
Copy link
MemberAuthor

2.28 cherry:#20585

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@mtojekmtojekmtojek approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnstcn@mafredri@mtojek@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp