Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: refactor terraform paths to a central structure#20566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Emyrk wants to merge4 commits intomain
base:main
Choose a base branch
Loading
fromstevenmasley/tf_workingdirectory

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedOct 29, 2025
edited
Loading

Refactors all Terraform file path logic into a centralized tfpath package. This consolidates all path construction into a single, testable Layout type.

Instead of passing aroundstring for directories, pass around theLayout which has the file location methods on it.

This design is also to support an experiment where the filepaths will be changed if the experiment is enabled. Allowing for a singular struct to determine filepath locations based on some config. The code that uses said paths will remain unchanged.

Prior Art

Inspired from ourcli handling of config files

typeRootstring

Naming

I was going back and forth on names. Some others I thought about:

  • tfpath
  • tfdir
  • tflayout
  • terradir

Thoughts

Should possibly addafero.FS to this type. Then our tests can run without using the actual FS 🤷

@EmyrkEmyrk marked this pull request as ready for reviewOctober 30, 2025 15:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp