- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: delete pending canceled prebuilds (#20499)#20554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
## DescriptionPR#20387 introduced cancelingpending prebuild jobs from inactive template versions to avoidprovisioning obsolete workspaces. However, the associated prebuildsremained in the database with "Canceled" status, visible in the UI.This PR now orphan-deletes these canceled prebuilt workspaces. Since thecanceled jobs were never processed by a provisioner, no Terraformresources were created, making orphan deletion safe.Orphan deletion always creates a provisioner job, but behavesdifferently based on provisioner availability:- If no provisioner daemon is available, the job is immediately markedas completed and the workspace is marked as deleted without anyprovisioner processing- If a provisioner daemon is available, it processes the delete job withempty Terraform state (no actual resources to destroy)The job cancellation and workspace deletion occur atomically in the sametransaction. We don't split this into two separate reconciliation runsbecause there's no way to distinguish between system-canceled prebuildsand user-canceled workspaces. If we deleted canceled workspaces in alater run, we'd delete user-canceled workspaces that users may want tokeep for troubleshooting.Note: This only applies to system-generated prebuilds from inactivetemplate versions.## Changes* Update `UpdatePrebuildProvisionerJobWithCancel` query to return jobID, workspace ID, template ID, and template version preset ID* Add `DeprovisionMode` enum to support orphan deletion in the provisionflow* Update `ActionTypeCancelPending` handler to cancel jobs andorphan-delete associated workspaces atomically(cherry picked from commitc3e3bb5)
david-fraley approved these changesOct 29, 2025
a7b3efb intorelease/2.28 32 of 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR:#20499
(cherry picked from commitc3e3bb5)