Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: delete pending canceled prebuilds (#20499)#20554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ssncferreira
Copy link
Contributor

Related to PR:#20499

(cherry picked from commitc3e3bb5)

## DescriptionPR#20387 introduced cancelingpending prebuild jobs from inactive template versions to avoidprovisioning obsolete workspaces. However, the associated prebuildsremained in the database with "Canceled" status, visible in the UI.This PR now orphan-deletes these canceled prebuilt workspaces. Since thecanceled jobs were never processed by a provisioner, no Terraformresources were created, making orphan deletion safe.Orphan deletion always creates a provisioner job, but behavesdifferently based on provisioner availability:- If no provisioner daemon is available, the job is immediately markedas completed and the workspace is marked as deleted without anyprovisioner processing- If a provisioner daemon is available, it processes the delete job withempty Terraform state (no actual resources to destroy)The job cancellation and workspace deletion occur atomically in the sametransaction. We don't split this into two separate reconciliation runsbecause there's no way to distinguish between system-canceled prebuildsand user-canceled workspaces. If we deleted canceled workspaces in alater run, we'd delete user-canceled workspaces that users may want tokeep for troubleshooting.Note: This only applies to system-generated prebuilds from inactivetemplate versions.## Changes* Update `UpdatePrebuildProvisionerJobWithCancel` query to return jobID, workspace ID, template ID, and template version preset ID* Add `DeprovisionMode` enum to support orphan deletion in the provisionflow* Update `ActionTypeCancelPending` handler to cancel jobs andorphan-delete associated workspaces atomically(cherry picked from commitc3e3bb5)
@johnstcnjohnstcn added the cherry-pick/v2.28Needs to be cherry-picked to the 2.28 release branch labelOct 29, 2025
@ssncferreirassncferreira merged commita7b3efb intorelease/2.28Oct 30, 2025
32 of 34 checks passed
@ssncferreirassncferreira deleted the ssncferreira/2.28-backport-20499 branchOctober 30, 2025 10:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@david-fraleydavid-fraleydavid-fraley approved these changes

Assignees

@ssncferreirassncferreira

Labels

cherry-pick/v2.28Needs to be cherry-picked to the 2.28 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssncferreira@david-fraley@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp