NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

chore(scaletest): avoid polling workspace builds during workspace-updates tests#20534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 1 commit intomainfromethan/avoid-polling-workspace-updates-scaletest

Oct 30, 2025

Merged

chore(scaletest): avoid polling workspace builds during workspace-updates tests#20534

ethanndickson merged 1 commit intomainfromethan/avoid-polling-workspace-updates-scaletest

Oct 30, 2025

Conversation

Copy link

Member

ethanndickson commentedOct 29, 2025•
edited
Loading

This PR is just committing the changes I made while running theworkspace-updates load generator.

It ensures we're not polling the workspace build progress in the background (while we also watch for workspace updates via the tailnet), and also removes an unnecessary query to/api/v2/workspace/{id} after each workspace is built.

chore(scaletest): avoid polling workspace builds during workspace-upd…

1066be0

…ates tests

github-actionsbot assignedethanndickson

Oct 29, 2025

Copy link

MemberAuthor

ethanndickson commentedOct 29, 2025

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ethanndickson commented

Oct 29, 2025

View reviewed changes

scaletest/workspacebuild/run.go

Comment on lines +36 to +39

		typeSlimWorkspacestruct {
		ID uuid.UUID
		Namestring
		}

Copy link

MemberAuthor

ethanndicksonOct 29, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm opting to return this new type here instead of thecodersdk.Workspace returned byCreateWorkspace, as I don't want callers ofRunReturningWorkspace to assume that thecodersdk.Workspace being returned contains the latest info about the build.