Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(site): fix disappearing preset selector when switching template#20514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 4 commits intomainfromdanielle/fix/preset-selector
Oct 29, 2025

Conversation

@DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedOct 28, 2025•
edited
Loading

Closes#20465

Ensure we setselectedPresetId toundefined when we changeselectedTemplateId to ensure we don't end up breaking the<Select> component by giving it an invalid preset id.

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewOctober 28, 2025 14:31
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but will happily defer to other reviewers' feedback.

@aslilac
Copy link
Member

thekey was added to intentionally unmount thestate of the old selector, so that it would be recomputed with a default from the new set of values.

@DanielleMaywood
Copy link
ContributorAuthor

@aslilac I've re-added thekey but added a check on theonValueChange. Let me know if you want a different approach

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm fine with this fix, but left some food for thought and would like to see a comment or something describing the pitfalls that the fix is supposed to smooth over

@johnstcnjohnstcn added the cherry-pick/v2.28Needs to be cherry-picked to the 2.28 release branch labelOct 29, 2025
@DanielleMaywoodDanielleMaywood merged commit9629d87 intomainOct 29, 2025
33 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/fix/preset-selector branchOctober 29, 2025 21:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels

cherry-pick/v2.28Needs to be cherry-picked to the 2.28 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Coder Tasks presets not set correctly when switching between templates

4 participants

@DanielleMaywood@aslilac@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp