- Notifications
You must be signed in to change notification settings - Fork925
feat: Authenticate Digital Ocean via environment variable#2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Cleanly written 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Noticed a bit more than DigitalOcean made it into this PR. Might want to edit the title before merging
| This template assumes that coderd is run in an environment that is authenticated | ||
| with Google Cloud. For example, run `gcloud auth application-default login` to import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think calling itcoderd is unclear in this case. This was the name for the Coder binary in Coder Classic, but we don't refer to it ascoderd in the user-facing product UI or documentation. I'd suggest calling it the "Coder host"
I did notice the code refers to it as "coderd"
Would like your thoughts though. We can merge and reconsider later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need a consistent set of terms for various components of the project / solution, and for v1 stuff moving forward (are we calling this "Coder Classic"!?). Perhaps you and I can collaborate on a RFC to this effect and get some more input.
It's really a drag to have different internal and external names down at the component level. Engineers will naturally screw up terminology in documents, customer interactions, etc. So, there has to be a really strong case for naming these things differently.
* Digital Ocean example uses environment variable authSigned-off-by: Spike Curtis <spike@coder.com>
Second PR addressing#1967
Still need K8s to call it done.