- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: update dbgen and dbfake task creation and toolsdk test fixtures#20508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
673cd3e to3c5414dCompare3c5414d to96a15edCompare| require.Fail(b.t,"task already has a workspace id, mismatch",task.WorkspaceID.UUID,b.ws.ID) | ||
| } | ||
| }elseiferrors.Is(err,sql.ErrNoRows) { | ||
| task:=dbgen.Task(b.t,b.db,b.taskSeed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm curious about this. Do we do this in the real workspace builder? If not, what's the motivation for it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not exactly but also yes. Logically it would make sense to create a TaskBuilder that can take a WorkspaceBuildBuilder and call.Do on it.
When we create a task we do so in a transaction which first creates the workspace, then the task, and then the workspace build. But workspace creation by itself never creates a task.
Uh oh!
There was an error while loading.Please reload this page.
a1fa58a intomainUh oh!
There was an error while loading.Please reload this page.
Depends on#20506
Fixescoder/internal#1103