- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add AWS Bedrock support#20507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Uh oh!
There was an error while loading.Please reload this page.
| ifcfg.Region.String()==""&&cfg.AccessKey.String()==""&&cfg.AccessKeySecret.String()=="" { | ||
| returnnil | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code in aibridge returned an error if model or small fast model wasn't set either. It's unlikely it won't be set since there is a default value, but technically it could still be unset by the user so you should still check that it's not empty here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need to do that here I think. There's validation that the model/small-fast-model are set when creating a client; this is just determining whether Bedrock is configured or not.
Signed-off-by: Danny Kopping <danny@coder.com>
d18441d intomainUh oh!
There was an error while loading.Please reload this page.
Depends oncoder/aibridge#44
Closescoder/aibridge#28