- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(coderd/database/dbfake): use transaction for workspace builder#20506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mafredri added a commit that referenced this pull requestOct 27, 2025
1c9d9a5 toc73b70cComparemafredri added a commit that referenced this pull requestOct 27, 2025
mafredri added a commit that referenced this pull requestOct 27, 2025
While investigating a flake I noticed that the dbfake workspace builderexecutes all database inserts without a transaction. Since our realwsbuilder implementation utilizes one it makes sense to do here as well.For example, our normal workspace <-> build relationship is such that aworkspace cannot exist with at least one build. However, ourGetWorkspaces query left joins workspace builds but has types that arenon-nullable, leading to flakes likecoder/internal#1103.
c73b70c to150882dComparesreya approved these changesOct 27, 2025
Collaborator
sreya left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, this is a good fine 👍
c3cbd97 intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating a flake I noticed that the dbfake workspace builder
executes all database inserts without a transaction. Since our real
wsbuilder implementation utilizes one it makes sense to do here as well.
For example, our normal workspace <-> build relationship is such that a
workspace cannot exist with at least one build. However, our
GetWorkspaces query left joins workspace builds but has types that are
non-nullable, leading to flakes likecoder/internal#1103.