- Notifications
You must be signed in to change notification settings - Fork1.1k
perf: optimize prebuilds membership reconciliation to check orgs not presets#20493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+397 −212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
1d3cbad to9648569Compare9648569 to9d47f64CompareUh oh!
There was an error while loading.Please reload this page.
johnstcn approved these changesOct 28, 2025
SasSwart approved these changesOct 29, 2025
7e8fcb4 intomain 30 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
The membership reconciliation ensures the prebuilds system user is a member of all organizations with prebuilds configured. To support prebuilds quota management, each organization must have a prebuilds group that the system user belongs to.
Problem
Previously, membership reconciliation iterated over all presets to check and update membership status. This meant database queries
GetGroupByOrgAndNameandInsertGroupMemberwere executed for each preset. Since presets are unique combinations of(organization, template, template version, preset), this resulted in several redundant checks for the same organization.In dogfood,
InsertGroupMemberwas called thousands of times per day, even though memberships were already configured (internal Grafana dashboard link)Solution
This PR introduces
GetOrganizationsWithPrebuildStatus, a single query that returns:The membership reconciliation logic now:
O(presets)toO(organizations)per reconciliation loop, with a single read query when everything is configured.Changes
GetOrganizationsWithPrebuildStatusSQL querymembership.ReconcileAllto use organization-based reconciliation instead of preset-basedRelated to internal thread:https://codercom.slack.com/archives/C07GRNNRW03/p1760535570381369