NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

fix: initialize pseudo console with default size for SSH sessions [2.26]#20491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

deansheather merged 1 commit intorelease/2.26fromdean/backport-win-pty-fix-2.26

Oct 28, 2025

Merged

fix: initialize pseudo console with default size for SSH sessions [2.26]#20491

deansheather merged 1 commit intorelease/2.26fromdean/backport-win-pty-fix-2.26

Oct 28, 2025

Conversation

Copy link

Member

deansheather commentedOct 27, 2025

Resolved an invalid parameter error (-2147024809) during PTY creation on Windows 11 22H2 (but not only) when connecting via JetBrains Toolbox which spawns the native SSH client with-tt forcing PTY allocation even though there is no "terminal" on the client side to query its size.
CreatePseudoConsole doesn't accept a 0x0 (zero width and zero height) console size and unfortunately, there is NO explicit documentation in the official Microsoft documentation that states the minimum valid values or explicitly prohibits 0x0.
Looking at real-world implementations in the search results, all examples use reasonable non-zero values.
I tested this with a local Windows VM registered to dev.coder.com i.e. externally managed workspace.

Relates to#20468

fix: initialize pseudo console with default size for SSH sessions (#2…

3428753

…0472)Resolved an invalid parameter error (-2147024809) during PTY creation onWindows 11 22H2 (but not only) when connecting via JetBrains Toolboxwhich spawns the native SSH client with `-tt` forcing PTY allocationeven though there is no "terminal" on the client side to query its size.CreatePseudoConsole doesn't accept a 0x0 (zero width and zero height)console size and unfortunately, there is NO explicit documentation inthe official Microsoft documentation that states the minimum validvalues or explicitly prohibits 0x0.Looking at real-world implementations in the search results, allexamples use reasonable non-zero values.I tested this with a local Windows VM registered to dev.coder.com i.e.externally managed workspace.Fixes:#20468(cherry picked from commitb890930)

deansheather requested review fromfioan89 andstirby

October 27, 2025 10:14

github-actionsbot assigneddeansheather

Oct 27, 2025

deansheather changed the title~~fix: initialize pseudo console with default size for SSH sessions (#2…~~fix: initialize pseudo console with default size for SSH sessions [2.26]

Oct 27, 2025