Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(cli/ssh): avoid swallowing unexpected http status codes#20487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedOct 27, 2025
edited
Loading

If you were to somehow get a 401, or some other unexpected HTTP status code when following a workspace's build logs,coder ssh would swallow the error, and give you a different error that didn't make sense.
In this case I was getting a 401 on/templateversions/{templateversion}/dry-run/{jobID}/logs , but the CLI error would say the workspace had no agents.

I ran into the 401 when running a scaletest, and then whilst attempting to reproduce the issue locally, I rancoder ssh from one build of Coder that usedcoder_session_token as the session token cookie name, whilst the other build useddev_coder_session_token (as set bydevelop.sh). For reference, the CLI uses cookies when following the build logs.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson changed the titlefix(cli): avoid swallowing unexpected http status codes when following workspace build logsfix(cli/ssh): avoid swallowing unexpected http status codesOct 27, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewOctober 27, 2025 05:41
@ethanndicksonethanndickson merged commit6318520 intomainOct 27, 2025
66 of 68 checks passed
@ethanndicksonethanndickson deleted the ethan/always-error-on-codersdk-err-build-logs branchOctober 27, 2025 05:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp