- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(cli/ssh): avoid swallowing unexpected http status codes#20487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…g workspace build logs
MemberAuthor
ethanndickson commentedOct 27, 2025
deansheather approved these changesOct 27, 2025
6318520 intomain 66 of 68 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading.Please reload this page.
If you were to somehow get a 401, or some other unexpected HTTP status code when following a workspace's build logs,
coder sshwould swallow the error, and give you a different error that didn't make sense.In this case I was getting a 401 on
/templateversions/{templateversion}/dry-run/{jobID}/logs, but the CLI error would say the workspace had no agents.I ran into the 401 when running a scaletest, and then whilst attempting to reproduce the issue locally, I ran
coder sshfrom one build of Coder that usedcoder_session_tokenas the session token cookie name, whilst the other build useddev_coder_session_token(as set bydevelop.sh). For reference, the CLI uses cookies when following the build logs.