- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: use temp file on same device with mcp file edit#20477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -250,7 +250,9 @@ func (a *agent) editFile(ctx context.Context, path string, edits []workspacesdk. | ||
| transforms[i] = replace.String(edit.Search, edit.Replace) | ||
| } | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Couldn't we pass the https://github.com/spf13/afero/blob/399bb34ad9fd8a252ad1d8bfaef96279b66dc774/ioutil.go#L180-L207 MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Holy smokes how did I miss that, thank you! Fixed. | ||
| // Create an adjacent file to ensure it will be on the same device and can be | ||
| // moved atomically. | ||
| tmpfile, err := afero.TempFile(a.filesystem, filepath.Dir(path), filepath.Base(path)) | ||
| if err != nil { | ||
| return http.StatusInternalServerError, err | ||
| } | ||
Uh oh!
There was an error while loading.Please reload this page.