- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: use temp file on same device with mcp file edit#20477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Otherwise you can get errors like "invalid cross-device link".
| transforms[i]=replace.String(edit.Search,edit.Replace) | ||
| } | ||
| tmpfile,err:=afero.TempFile(a.filesystem,"",filepath.Base(path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Couldn't we pass thefilepath.Dir(path) here instead of the empty string and get almost the same behavior?
https://github.com/spf13/afero/blob/399bb34ad9fd8a252ad1d8bfaef96279b66dc774/ioutil.go#L180-L207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Holy smokes how did I miss that, thank you! Fixed.
643fe38 intomainUh oh!
There was an error while loading.Please reload this page.
Otherwise you can get errors like "invalid cross-device link".