- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: show build timeline regardless of agent scripts count#20470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+47 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Prior would only display is >0 existed. If scripts are still being run,the agent script timings could be incomplete. The UI should refetchif more scripts are expected.
BrunoQuaresma approved these changesOct 27, 2025
Contributor
BrunoQuaresma left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I do not think the UI needs to know definitively if all scripts are done. If so, maybe the agent needs to submit some entry that signals "all RunOnStart scripts complete".
I do agree with you 👍
LGTM 🚢 it
ffe22a0 intomain 31 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Prior would only display if >0 script timings existed. A template can have 0
RunOnStartscripts, and report 0 timings.If scripts are still being run, the agent script timings could be incomplete. However, UI should refetch if more scripts are expected.
I do not think the UI needs to know definitively if all scripts are done. If so, maybe the agent needs to submit some entry that signals "all
RunOnStartscripts complete".Before
The
fasttemplate on dogfood showcases this bug.