Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: show build timeline regardless of agent scripts count#20470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 3 commits intomainfromstevenmasley/build_timeline_loading
Oct 27, 2025

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedOct 24, 2025•
edited
Loading

Prior would only display if >0 script timings existed. A template can have 0RunOnStart scripts, and report 0 timings.

If scripts are still being run, the agent script timings could be incomplete. However, UI should refetch if more scripts are expected.

I do not think the UI needs to know definitively if all scripts are done. If so, maybe the agent needs to submit some entry that signals "allRunOnStart scripts complete".

Before

Thefast template on dogfood showcases this bug.

Screenshot From 2025-10-24 14-17-43

Prior would only display is >0 existed. If scripts are still being run,the agent script timings could be incomplete. The UI should refetchif more scripts are expected.
@EmyrkEmyrk changed the titlechore: build timeline should still be shown when 0 agent scripts existchore: show build timeline regardless of agent scripts countOct 24, 2025
@EmyrkEmyrk requested review fromBrunoQuaresma and removed request forParkreiner andaslilacOctober 24, 2025 19:18
Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I do not think the UI needs to know definitively if all scripts are done. If so, maybe the agent needs to submit some entry that signals "all RunOnStart scripts complete".

I do agree with you 👍

LGTM 🚢 it

@EmyrkEmyrk merged commitffe22a0 intomainOct 27, 2025
31 checks passed
@EmyrkEmyrk deleted the stevenmasley/build_timeline_loading branchOctober 27, 2025 15:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp