Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Make workspace timeline rows obviously clickable#2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedJun 3, 2022•
edited
Loading

This PR make workspace timeline rows obviously clickable.

Subtasks

  • added the right arrow
  • update the hover background color
  • apply the same to workspace list
  • remove existing link on the workspace name
  • apply the same to templates list
  • remove existing link on the template name

Fixes#2021
Fixes#2058

Screenshot

Timeline (with hover)

Screen Shot 2022-06-03 at 4 19 19 PM

Templates list

Screen Shot 2022-06-06 at 9 42 56 PM

Workspaces list

Screen Shot 2022-06-06 at 9 42 46 PM

@ammario
Copy link
Member

The grey background looks like it's hovered and not clickable.

I think the Chevron-only is better.

@AbhineetJain
Copy link
ContributorAuthor

The grey background looks like it's hovered and not clickable.

The grey background is only when it is hovered. The screenshot is from when the row is hovered upon.

@f0ssel
Copy link
Contributor

Doesn't have to be this PR, but could we get this treatment on the templates page?@kylecarbs and I just talked about this improvement and think it would help with pushing users to an action on the templates page.

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/2021-make-rows-obviously-clickable branch from7d9db12 tod29238bCompareJune 7, 2022 01:48
@AbhineetJainAbhineetJain marked this pull request as ready for reviewJune 7, 2022 02:40
@AbhineetJainAbhineetJain requested a review froma team as acode ownerJune 7, 2022 02:40
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great work!

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/2021-make-rows-obviously-clickable branch fromc553981 to5834755CompareJune 7, 2022 18:51
@AbhineetJain
Copy link
ContributorAuthor

@presleyp@BrunoQuaresma Can you help with approving the updated UI tests? If you believe I can do that myself, that also works.

presleyp reacted with thumbs up emoji

@AbhineetJainAbhineetJainenabled auto-merge (squash)June 7, 2022 19:11
@AbhineetJainAbhineetJain merged commit4b82509 intomainJun 7, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/2021-make-rows-obviously-clickable branchJune 7, 2022 19:11
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
…2047)* add right arrow to build table rows* Add clickable rows to template and workspace list* Specify 1% width for chevron right
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entire row in workspaces list should be clickable Make workspace timeline rows obviously clickable
4 participants
@AbhineetJain@ammario@f0ssel@presleyp
[8]ページ先頭
©2009-2025 Movatter.jp