Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: fix flake in TestAgent_Metrics_SSH#20450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/agent-metrics-flake
Oct 24, 2025

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedOct 24, 2025•
edited
Loading

Second flake for this test today 😮‍💨.

Flake seen here, though I couldn't replicate this locally, some CI exclusive networking issue.
https://github.com/coder/coder/actions/runs/18770305895/job/53553517887?pr=20448

    agent_test.go:3619:         Error Trace:/home/runner/work/coder/coder/agent/agent_test.go:3619        Error:      Received unexpected error:                    expected 1, got 0.000000:                        github.com/coder/coder/v2/agent_test.TestAgent_Metrics_SSH.func7                            /home/runner/work/coder/coder/agent/agent_test.go:3557        Test:       TestAgent_Metrics_SSH        Messages:   check fn for coderd_agentstats_currently_reachable_peers failed

This value is incremented by a successful ping to the peer from the agent, which is dependent on all the networking code, which I think is definitely out of scope of this test for agent metrics. So, we'll just assert that the metrics exist with the correct labels (derp,p2p)

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson marked this pull request as ready for reviewOctober 24, 2025 06:16
@ethanndicksonethanndickson merged commit33b42fc intomainOct 24, 2025
41 checks passed
@ethanndicksonethanndickson deleted the ethan/agent-metrics-flake branchOctober 24, 2025 06:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp