- Notifications
You must be signed in to change notification settings - Fork928
fix: add copy fallback for insecure contexts#2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🙌🏻
I'm wondering if@mafredri can help us test :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tried this out and it doesn't seem to do anything on any of my browsers (Safari, Firefox, Brave). It also doesn't log anything in the console which would indicateresult === true.
Perhapsinput.hidden = true can't be selected? What if we use CSS to hide it instead?
PS. Thanks for taking a stab at fixing this@oxy!
8b26144 to58cd3edCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works now, awesome! 😎
This PR adds a clipboard copy fallback for insecure contexts.
Subtasks
Fixes#1601