- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: remove references to dbtestutil.WillUsePostgres#20436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Since we removed the in-memory database and now only use Postgres,the WillUsePostgres() function always returned true. This commit:- Removes all test skip conditions that checked WillUsePostgres- Removes the WillUsePostgres function from dbtestutil- Simplifies ErrorsWithPG to always call Errors- Marks ErrorsWithInMemDB as deprecated (kept for compatibility)Fixescoder/internal#758Co-authored-by: hugodutka <28019628+hugodutka@users.noreply.github.com>
The in-memory database has been removed, so ErrorsWithInMemDBis no longer needed. This removes:- The ErrorsWithInMemDB function definition from setup_test.go- The single usage of ErrorsWithInMemDB in dbauthz_test.goCo-authored-by: hugodutka <28019628+hugodutka@users.noreply.github.com>
Since we removed the in-memory database, ErrorsWithPG is nowidentical to Errors. This removes:- The ErrorsWithPG function definition from setup_test.go- Replaces the single usage of ErrorsWithPG with ErrorsCo-authored-by: hugodutka <28019628+hugodutka@users.noreply.github.com>
35ca99b to506bf89Comparedeansheather approved these changesOct 23, 2025
e62c5db intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressescoder/internal#758.
This PR only cleans up dead code, it makes no changes to test logic.