Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd/provisionerdserver): pipe through task id and prompt#20408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 3 commits intomainfromdanielle/provisioner-task
Oct 24, 2025

Conversation

@DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedOct 22, 2025•
edited
Loading

Pipes through the Task's ID and prompt into the provisioner. This is required to support the newcoder_ai_task.prompt field and modifiedcoder_ai_task.id field.

@mafredrimafredriforce-pushed themafredri/refactor-coderd-use-tasks-data-model-in-list branch 5 times, most recently from0e77536 to39eca6aCompareOctober 22, 2025 13:39
@mafredrimafredriforce-pushed themafredri/refactor-coderd-use-tasks-data-model-in-list branch from39eca6a to316b12bCompareOctober 22, 2025 14:03
@DanielleMaywoodDanielleMaywoodforce-pushed thedanielle/provisioner-task branch 2 times, most recently from9299e77 to625db35CompareOctober 22, 2025 14:09
@mafredrimafredriforce-pushed themafredri/refactor-coderd-use-tasks-data-model-in-list branch 3 times, most recently from5fc4328 toef433ccCompareOctober 23, 2025 08:37
@mafredrimafredriforce-pushed themafredri/refactor-coderd-use-tasks-data-model-in-list branch 4 times, most recently from8fd3604 to6cc3b03CompareOctober 23, 2025 14:57
@mafredrimafredriforce-pushed themafredri/refactor-coderd-use-tasks-data-model-in-list branch 8 times, most recently from9220413 toe605686CompareOctober 23, 2025 17:11
Base automatically changed frommafredri/refactor-coderd-use-tasks-data-model-in-list tomainOctober 23, 2025 17:22
@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewOctober 24, 2025 08:24
vartaskIDstring
task,err:=s.Database.GetTaskByWorkspaceID(ctx,workspaceBuild.WorkspaceID)
iferr!=nil&&!errors.Is(err,sql.ErrNoRows) {
returnnil,xerrors.Errorf("failed to get task by workspace id: %w",err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
returnnil,xerrors.Errorf("failed toget task by workspace id: %w",err)
returnnil,xerrors.Errorf("get task by workspace id: %w",err)

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but this change makes me think we should move prompt to thetask_workspace_apps table (and maybe that's a bad name for it) 😅

This would essentially always feed the same prompt into the task, right?

@DanielleMaywood
Copy link
ContributorAuthor

This would essentially always feed the same prompt into the task, right?

Yep

@DanielleMaywoodDanielleMaywood merged commit5a31c59 intomainOct 24, 2025
30 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/provisioner-task branchOctober 24, 2025 08:43
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DanielleMaywood@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp