Oct 21, 2025 · Oct 21, 2025 · Oct 21, 2025
diff --git a/.golangci.yaml b/.golangci.yaml
      - name: var-declaration
      - name: var-naming
      - name: waitgroup-by-value
  usetesting:
    # Only os-setenv is enabled because we migrated to usetesting from another linter that
    # only covered os-setenv.
    os-setenv: true
    os-create-temp: false
    os-mkdir-temp: false
    os-temp-dir: false
    os-chdir: false
    context-background: false
    context-todo: false

  # irrelevant as of Go v1.22: https://go.dev/blog/loopvar-preview
  govet:
    # - wastedassign

    - staticcheck
    - tenv
    # In Go, it's possible for a package to test it's internal functionality
    # without testing any exported functions. This is enabled to promote
    # decomposing a package before testing it's internals. A function caller
    - typecheck
    - unconvert
    - unused
    - usetesting
    - dupl
diff --git a/coderd/util/tz/tz_test.go b/coderd/util/tz/tz_test.go
 // This test can be flaky on some Windows runners :(
 t.Skip("This test is flaky under Windows.")
 }
 oldEnv, found := os.LookupEnv("TZ")
 _, found := os.LookupEnv("TZ")
 if found {
 require.NoError(t, os.Unsetenv("TZ"))
 t.Cleanup(func() {
 _ = os.Setenv("TZ", oldEnv)
 })
 }

 zone, err := tz.TimezoneIANA()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -169,6 +169,16 @@ linters-settings:
		- name: var-declaration
		- name: var-naming
		- name: waitgroup-by-value
		usetesting:
		# Only os-setenv is enabled because we migrated to usetesting from another linter that
		# only covered os-setenv.
		os-setenv: true
		os-create-temp: false
		os-mkdir-temp: false
		os-temp-dir: false
		os-chdir: false
		context-background: false
		context-todo: false

		# irrelevant as of Go v1.22: https://go.dev/blog/loopvar-preview
		govet:
Expand DownExpand Up		@@ -252,7 +262,6 @@ linters:
		# - wastedassign

		- staticcheck
		- tenv
		# In Go, it's possible for a package to test it's internal functionality
		# without testing any exported functions. This is enabled to promote
		# decomposing a package before testing it's internals. A function caller
Expand All		@@ -265,4 +274,5 @@ linters:
		- typecheck
		- unconvert
		- unused
		- usetesting
		- dupl
Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,12 +35,9 @@ func Test_TimezoneIANA(t *testing.T) {
		// This test can be flaky on some Windows runners :(
		t.Skip("This test is flaky under Windows.")
		}
		oldEnv, found := os.LookupEnv("TZ")
		_, found := os.LookupEnv("TZ")
		if found {
		require.NoError(t, os.Unsetenv("TZ"))
		t.Cleanup(func() {
		_ = os.Setenv("TZ", oldEnv)
Copy link ContributorAuthor zedkippOct 21, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This`os.Setenv` call is flagged by the new linter. It's not needed because the`t.Setenv` call in this test cleans up the environment for ushttps://pkg.go.dev/testing#T.Setenv
		})
		}

		zone, err := tz.TimezoneIANA()
Expand Down