- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: migrate from tenv linter to usetesting linter#20401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tenv is deprecated in favor of usetesting which offers a supersetof lint checks. usetesting is configured for linting parity.
zedkipp commentedOct 21, 2025
| iffound { | ||
| require.NoError(t,os.Unsetenv("TZ")) | ||
| t.Cleanup(func() { | ||
| _=os.Setenv("TZ",oldEnv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thisos.Setenv call is flagged by the new linter. It's not needed because thet.Setenv call in this test cleans up the environment for ushttps://pkg.go.dev/testing#T.Setenv
johnstcn approved these changesOct 21, 2025
9da60a9 intomain 80 of 82 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The tenv linter is deprecated in favor of usetesting which offers a superset of lint checks. This message is seen when running
make lintThis PR swaps out the deprecated tenv linter for the usetesting linter, and configures it for linting parity.
#20398