- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: centralize warning message in static error#20389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
site/static/error.html Outdated
| </div> | ||
| </body> | ||
| <head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the prettier code style is that<head> and<body> both should be indented
site/static/error.html Outdated
| p, | ||
| li { | ||
| color:rgb(161,161,170); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should still be a hex color
site/static/error.html Outdated
| p, | ||
| li { | ||
| color:rgb(161,161,170); | ||
| line-height:22.4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
22.4px is a specific enough value to deserve a rationale comment. why not a percent anymore? why not22px?
site/static/error.html Outdated
| padding-top:10px; | ||
| margin-left:30px; | ||
| font-size:14px; | ||
| line-height:25.6px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
another very oddline-height choice
site/static/error.html Outdated
| } | ||
| .warningli { | ||
| text-align: left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
where is the center align coming from? manually left aligning things that should just be left aligned feels like a bit of a bandaid
site/static/error.html Outdated
| background:rgb(13,19,33); | ||
| width:100%; | ||
| padding:24px; | ||
| text-align: left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
BrunoQuaresma commentedOct 21, 2025
Not sure what I did to cause this diff 😓 I only changed a few lines, but it looks like something else got picked up too. |
aslilac left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
also I think prettier usually lowercases hex colors. maybe try formatting it one more time? I guess this file is ignored because it's in static/ which is a bit unfortunate
site/static/error.html Outdated
| This template is used by application handlers to render friendly error pages | ||
| when there is a proxy error (for example, when the target app isn't running). | ||
| Since it is served from subdomains, both on proxies and the primary, it MUST | ||
| NOT access any external resources. It must be entirely self-contained. This | ||
| includes anything in `/static` or `/icon`, as these are not served from | ||
| subdomains. | ||
| Since it is served from subdomains, both on proxies and the primary, it MUST | ||
| NOT access any external resources. It must be entirely self-contained. This | ||
| includes anything in `/static` or `/icon`, as these are not served from | ||
| subdomains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
maybe re-indent this comment if that also wasn't intentional?
site/static/error.html Outdated
| font-size:24px; | ||
| margin-bottom:8px; | ||
| font-weight:400; | ||
| color:#FFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: for #fff and #000 I like to just usewhite andblack as it's slightly faster to read
87ce021 intomainUh oh!
There was an error while loading.Please reload this page.
Before:
After:
Fixes#20369