Oct 24, 2025 · Oct 20, 2025 · Oct 21, 2025 · Oct 21, 2025 · Oct 22, 2025 · Oct 22, 2025
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return q.db.CountInProgressPrebuilds(ctx)
 }

 func (q *querier) CountPendingNonActivePrebuilds(ctx context.Context) ([]database.CountPendingNonActivePrebuildsRow, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceWorkspace.All()); err != nil {
 return nil, err
 }
 return q.db.CountPendingNonActivePrebuilds(ctx)
 }

 func (q *querier) CountUnreadInboxNotificationsByUserID(ctx context.Context, userID uuid.UUID) (int64, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceInboxNotification.WithOwner(userID.String())); err != nil {
 return 0, err
 return deleteQ(q.log, q.auth, q.db.GetOrganizationByID, deleteF)(ctx, arg.ID)
 }

 func (q *querier) UpdatePrebuildProvisionerJobWithCancel(ctx context.Context, arg database.UpdatePrebuildProvisionerJobWithCancelParams) ([]uuid.UUID, error) {
 // Prebuild operation for canceling pending prebuild jobs from non-active template versions
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourcePrebuiltWorkspace); err != nil {
 return []uuid.UUID{}, err
 }
 return q.db.UpdatePrebuildProvisionerJobWithCancel(ctx, arg)
 }

 func (q *querier) UpdatePresetPrebuildStatus(ctx context.Context, arg database.UpdatePresetPrebuildStatusParams) error {
 preset, err := q.db.GetPresetByID(ctx, arg.PresetID)
 if err != nil {
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
 dbm.EXPECT().UpdateProvisionerJobWithCancelByID(gomock.Any(), arg).Return(nil).AnyTimes()
 check.Args(arg).Asserts(v.RBACObject(tpl), []policy.Action{policy.ActionRead, policy.ActionUpdate}).Returns()
 }))
 s.Run("UpdatePrebuildProvisionerJobWithCancel", s.Mocked(func(dbm *dbmock.MockStore, faker *gofakeit.Faker, check *expects) {
 arg := database.UpdatePrebuildProvisionerJobWithCancelParams{
 PresetID: uuid.NullUUID{UUID: uuid.New(), Valid: true},
 Now:      dbtime.Now(),
 }
 jobIDs := []uuid.UUID{uuid.New(), uuid.New()}

 dbm.EXPECT().UpdatePrebuildProvisionerJobWithCancel(gomock.Any(), arg).Return(jobIDs, nil).AnyTimes()
 check.Args(arg).Asserts(rbac.ResourcePrebuiltWorkspace, policy.ActionUpdate).Returns(jobIDs)
 }))
 s.Run("GetProvisionerJobsByIDs", s.Mocked(func(dbm *dbmock.MockStore, faker *gofakeit.Faker, check *expects) {
 org := testutil.Fake(s.T(), faker, database.Organization{})
 org2 := testutil.Fake(s.T(), faker, database.Organization{})
 dbm.EXPECT().CountInProgressPrebuilds(gomock.Any()).Return([]database.CountInProgressPrebuildsRow{}, nil).AnyTimes()
 check.Args().Asserts(rbac.ResourceWorkspace.All(), policy.ActionRead)
 }))
 s.Run("CountPendingNonActivePrebuilds", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
 dbm.EXPECT().CountPendingNonActivePrebuilds(gomock.Any()).Return([]database.CountPendingNonActivePrebuildsRow{}, nil).AnyTimes()
 check.Args().Asserts(rbac.ResourceWorkspace.All(), policy.ActionRead)
 }))
 s.Run("GetPresetsAtFailureLimit", s.Mocked(func(dbm *dbmock.MockStore, _ *gofakeit.Faker, check *expects) {
 dbm.EXPECT().GetPresetsAtFailureLimit(gomock.Any(), int64(0)).Return([]database.GetPresetsAtFailureLimitRow{}, nil).AnyTimes()
 check.Args(int64(0)).Asserts(rbac.ResourceTemplate.All(), policy.ActionViewInsights)
diff --git a/coderd/database/dbfake/dbfake.go b/coderd/database/dbfake/dbfake.go
 resources  []*sdkproto.Resource
 params     []database.WorkspaceBuildParameter
 agentTokenstring
 dispoworkspaceBuildDisposition
 jobStatus  database.ProvisionerJobStatus
 taskAppID  uuid.UUID
 }

 typeworkspaceBuildDispositionstruct {
 startingbool
 }

 // WorkspaceBuild generates a workspace build for the provided workspace.
 // Pass a database.Workspace{} with a nil ID to also generate a new workspace.
 // Omitting the template ID on a workspace will also generate a new template
 }

 func (bWorkspaceBuildBuilder)Starting()WorkspaceBuildBuilder {
 //nolint: revive // returns modified struct
 b.dispo.starting=true
 b.jobStatus=database.ProvisionerJobStatusRunning
 returnb
 }

 func (bWorkspaceBuildBuilder)Pending()WorkspaceBuildBuilder {
 b.jobStatus=database.ProvisionerJobStatusPending
 returnb
 }

 func (bWorkspaceBuildBuilder)Canceled()WorkspaceBuildBuilder {
 b.jobStatus=database.ProvisionerJobStatusCanceled
 returnb
 }

 require.NoError(b.t,err,"insert job")
 b.logger.Debug(context.Background(),"inserted provisioner job",slog.F("job_id",job.ID))

 ifb.dispo.starting {
 switchb.jobStatus {
 casedatabase.ProvisionerJobStatusPending:
 // Provisioner jobs are created in 'pending' status
 b.logger.Debug(context.Background(),"pending the provisioner job")
 casedatabase.ProvisionerJobStatusRunning:
 // might need to do this multiple times if we got a template version
 // import job as well
 b.logger.Debug(context.Background(),"looping to acquire provisioner job")
 break
 }
 }
 }else {
 casedatabase.ProvisionerJobStatusCanceled:
 // Set provisioner job status to 'canceled'
 b.logger.Debug(context.Background(),"canceling the provisioner job")
 err=b.db.UpdateProvisionerJobWithCancelByID(ownerCtx, database.UpdateProvisionerJobWithCancelByIDParams{
 ID:jobID,
 CanceledAt: sql.NullTime{
 Time:dbtime.Now(),
 Valid:true,
 },
 CompletedAt: sql.NullTime{
 Time:dbtime.Now(),
 Valid:true,
 },
 })
 require.NoError(b.t,err,"cancel job")
 default:
 // By default, consider jobs in 'succeeded' status
 b.logger.Debug(context.Background(),"completing the provisioner job")
 err=b.db.UpdateProvisionerJobWithCompleteByID(ownerCtx, database.UpdateProvisionerJobWithCompleteByIDParams{
 ID:job.ID,
 t.params[i]=dbgen.TemplateVersionParameter(t.t,t.db,param)
 }

 // Update response with template and version
 ifresp.Template.ID==uuid.Nil&&version.TemplateID.Valid {
 template,err:=t.db.GetTemplateByID(ownerCtx,version.TemplateID.UUID)
 require.NoError(t.t,err)
 resp.Template=template
 }
 resp.TemplateVersion=version
 returnresp
 }
diff --git a/coderd/database/dbmetrics/querymetrics.go b/coderd/database/dbmetrics/querymetrics.go
diff --git a/coderd/database/dbmock/dbmock.go b/coderd/database/dbmock/dbmock.go
diff --git a/coderd/database/querier.go b/coderd/database/querier.go
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1512,6 +1512,13 @@ func (q *querier) CountInProgressPrebuilds(ctx context.Context) ([]database.Coun
		return q.db.CountInProgressPrebuilds(ctx)
		}

		func (q *querier) CountPendingNonActivePrebuilds(ctx context.Context) ([]database.CountPendingNonActivePrebuildsRow, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceWorkspace.All()); err != nil {
		return nil, err
		}
		return q.db.CountPendingNonActivePrebuilds(ctx)
		}

		func (q *querier) CountUnreadInboxNotificationsByUserID(ctx context.Context, userID uuid.UUID) (int64, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceInboxNotification.WithOwner(userID.String())); err != nil {
		return 0, err
Expand DownExpand Up		@@ -4875,6 +4882,14 @@ func (q *querier) UpdateOrganizationDeletedByID(ctx context.Context, arg databas
		return deleteQ(q.log, q.auth, q.db.GetOrganizationByID, deleteF)(ctx, arg.ID)
		}

		func (q *querier) UpdatePrebuildProvisionerJobWithCancel(ctx context.Context, arg database.UpdatePrebuildProvisionerJobWithCancelParams) ([]uuid.UUID, error) {
		// Prebuild operation for canceling pending prebuild jobs from non-active template versions
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourcePrebuiltWorkspace); err != nil {
		return []uuid.UUID{}, err
		}
		return q.db.UpdatePrebuildProvisionerJobWithCancel(ctx, arg)
		}

		func (q *querier) UpdatePresetPrebuildStatus(ctx context.Context, arg database.UpdatePresetPrebuildStatusParams) error {
		preset, err := q.db.GetPresetByID(ctx, arg.PresetID)
		if err != nil {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -641,6 +641,16 @@ func (s *MethodTestSuite) TestProvisionerJob() {
		dbm.EXPECT().UpdateProvisionerJobWithCancelByID(gomock.Any(), arg).Return(nil).AnyTimes()
		check.Args(arg).Asserts(v.RBACObject(tpl), []policy.Action{policy.ActionRead, policy.ActionUpdate}).Returns()
		}))
		s.Run("UpdatePrebuildProvisionerJobWithCancel", s.Mocked(func(dbm dbmock.MockStore, faker gofakeit.Faker, check *expects) {
		arg := database.UpdatePrebuildProvisionerJobWithCancelParams{
		PresetID: uuid.NullUUID{UUID: uuid.New(), Valid: true},
		Now: dbtime.Now(),
		}
		jobIDs := []uuid.UUID{uuid.New(), uuid.New()}

		dbm.EXPECT().UpdatePrebuildProvisionerJobWithCancel(gomock.Any(), arg).Return(jobIDs, nil).AnyTimes()
		check.Args(arg).Asserts(rbac.ResourcePrebuiltWorkspace, policy.ActionUpdate).Returns(jobIDs)
		}))
		s.Run("GetProvisionerJobsByIDs", s.Mocked(func(dbm dbmock.MockStore, faker gofakeit.Faker, check *expects) {
		org := testutil.Fake(s.T(), faker, database.Organization{})
		org2 := testutil.Fake(s.T(), faker, database.Organization{})
Expand DownExpand Up		@@ -3758,6 +3768,10 @@ func (s *MethodTestSuite) TestPrebuilds() {
		dbm.EXPECT().CountInProgressPrebuilds(gomock.Any()).Return([]database.CountInProgressPrebuildsRow{}, nil).AnyTimes()
		check.Args().Asserts(rbac.ResourceWorkspace.All(), policy.ActionRead)
		}))
		s.Run("CountPendingNonActivePrebuilds", s.Mocked(func(dbm dbmock.MockStore, _ gofakeit.Faker, check *expects) {
		dbm.EXPECT().CountPendingNonActivePrebuilds(gomock.Any()).Return([]database.CountPendingNonActivePrebuildsRow{}, nil).AnyTimes()
		check.Args().Asserts(rbac.ResourceWorkspace.All(), policy.ActionRead)
		}))
		s.Run("GetPresetsAtFailureLimit", s.Mocked(func(dbm dbmock.MockStore, _ gofakeit.Faker, check *expects) {
		dbm.EXPECT().GetPresetsAtFailureLimit(gomock.Any(), int64(0)).Return([]database.GetPresetsAtFailureLimitRow{}, nil).AnyTimes()
		check.Args(int64(0)).Asserts(rbac.ResourceTemplate.All(), policy.ActionViewInsights)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -55,14 +55,10 @@ type WorkspaceBuildBuilder struct {
		resources []*sdkproto.Resource
		params []database.WorkspaceBuildParameter
		agentTokenstring
		dispoworkspaceBuildDisposition
		jobStatus database.ProvisionerJobStatus
		taskAppID uuid.UUID
		}

		typeworkspaceBuildDispositionstruct {
		startingbool
		}

		// WorkspaceBuild generates a workspace build for the provided workspace.
		// Pass a database.Workspace{} with a nil ID to also generate a new workspace.
		// Omitting the template ID on a workspace will also generate a new template
Expand DownExpand Up		@@ -145,8 +141,17 @@ func (b WorkspaceBuildBuilder) WithTask(seed *sdkproto.App) WorkspaceBuildBuilde
		}

		func (bWorkspaceBuildBuilder)Starting()WorkspaceBuildBuilder {
		//nolint: revive // returns modified struct
		b.dispo.starting=true
		b.jobStatus=database.ProvisionerJobStatusRunning
		returnb
		}

		func (bWorkspaceBuildBuilder)Pending()WorkspaceBuildBuilder {
		b.jobStatus=database.ProvisionerJobStatusPending
		returnb
		}

		func (bWorkspaceBuildBuilder)Canceled()WorkspaceBuildBuilder {
		b.jobStatus=database.ProvisionerJobStatusCanceled
		returnb
		}

Expand DownExpand Up		@@ -231,7 +236,11 @@ func (b WorkspaceBuildBuilder) Do() WorkspaceResponse {
		require.NoError(b.t,err,"insert job")
		b.logger.Debug(context.Background(),"inserted provisioner job",slog.F("job_id",job.ID))

		ifb.dispo.starting {
		switchb.jobStatus {
		casedatabase.ProvisionerJobStatusPending:
		// Provisioner jobs are created in 'pending' status
		b.logger.Debug(context.Background(),"pending the provisioner job")
		casedatabase.ProvisionerJobStatusRunning:
		// might need to do this multiple times if we got a template version
		// import job as well
		b.logger.Debug(context.Background(),"looping to acquire provisioner job")
Expand All		@@ -255,7 +264,23 @@ func (b WorkspaceBuildBuilder) Do() WorkspaceResponse {
		break
		}
		}
		}else {
		casedatabase.ProvisionerJobStatusCanceled:
		// Set provisioner job status to 'canceled'
		b.logger.Debug(context.Background(),"canceling the provisioner job")
		err=b.db.UpdateProvisionerJobWithCancelByID(ownerCtx, database.UpdateProvisionerJobWithCancelByIDParams{
		ID:jobID,
		CanceledAt: sql.NullTime{
		Time:dbtime.Now(),
		Valid:true,
		},
		CompletedAt: sql.NullTime{
		Time:dbtime.Now(),
		Valid:true,
		},
		})
		require.NoError(b.t,err,"cancel job")
		default:
		// By default, consider jobs in 'succeeded' status
		b.logger.Debug(context.Background(),"completing the provisioner job")
		err=b.db.UpdateProvisionerJobWithCompleteByID(ownerCtx, database.UpdateProvisionerJobWithCompleteByIDParams{
		ID:job.ID,
Expand DownExpand Up		@@ -571,6 +596,12 @@ func (t TemplateVersionBuilder) Do() TemplateVersionResponse {
		t.params[i]=dbgen.TemplateVersionParameter(t.t,t.db,param)
		}

		// Update response with template and version
		ifresp.Template.ID==uuid.Nil&&version.TemplateID.Valid {
		template,err:=t.db.GetTemplateByID(ownerCtx,version.TemplateID.UUID)
		require.NoError(t.t,err)
		resp.Template=template
		}
		resp.TemplateVersion=version
		returnresp
		}
Expand Down