- Notifications
You must be signed in to change notification settings - Fork927
fix: Remove unused workspace routes in favor of list with filter#2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This consolidates the workspace routes into a single place.It allows users to fetch a workspace by their username andworkspace name, which will be used by the frontend for routing.
cli/autostart.go Outdated
| workspace, err := client.WorkspaceByOwnerAndName(cmd.Context(),organization.ID,codersdk.Me, args[0]) | ||
| workspace, err := client.WorkspaceByOwnerAndName(cmd.Context(), codersdk.Me, args[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might conflict with#2036!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup, but in a great way. We'll no longer need organization IDs to query workspaces since they are namespaced!
eee1232 to4efc4beCompare* fix: Remove unused workspace routes in favor of list with filterThis consolidates the workspace routes into a single place.It allows users to fetch a workspace by their username andworkspace name, which will be used by the frontend for routing.* Fix RBAC* Fix CLI usages
Uh oh!
There was an error while loading.Please reload this page.
This consolidates the workspace routes into a single place.
It allows users to fetch a workspace by their username and
workspace name, which will be used by the frontend for routing.
This fixes all frontend pages using the old routes too, which only
seems to be the terminal page!