- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(site): make TaskPrompt PromptTextarea read-only when submitting#20363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
BrunoQuaresma commentedOct 17, 2025
Could you share a quick screen recording showing how the changes look? It would also be great to add a Story for that change. |
johnstcn commentedOct 17, 2025
Added! I'll get to work on the storybook changes. |
BrunoQuaresma commentedOct 17, 2025
I’m not sure about the cursor animation though. I think it has too much movement. Maybe double-check with a PM? 🤔 |
johnstcn commentedOct 17, 2025
I updated the animation to be a little less 'busy'. |
BrunoQuaresma commentedOct 17, 2025
Just one more thing: we’re using Tailwind CSS now, so defining styles like that is an anti-pattern. This might help:https://tailwindcss.com/docs/animation. Maybe Claude Code could help with this. |
johnstcn commentedOct 17, 2025
e2295fa (and Claude did) |
DanielleMaywood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sold on the cursor animation but we have a couple weeks until code-freeze so plenty of time to decide we do/don't like it
f6526b7 intomainUh oh!
There was an error while loading.Please reload this page.
michaelvp411 commentedOct 17, 2025
PR SummaryThis PR improves the user experience of the TaskPrompt component by making the textarea read-only during submission. Changes:
Impact: |
Uh oh!
There was an error while loading.Please reload this page.
Screen.Recording.2025-10-17.at.17.35.53.mov