NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

feat(site): make TaskPrompt PromptTextarea read-only when submitting#20363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 5 commits intomainfromcj/task-textarea-readonly-submit

Oct 17, 2025

Merged

feat(site): make TaskPrompt PromptTextarea read-only when submitting#20363

johnstcn merged 5 commits intomainfromcj/task-textarea-readonly-submit

Oct 17, 2025

Conversation

Copy link

Member

johnstcn commentedOct 17, 2025•
edited
Loading

Makes the text area of TaskPrompt read-only when submitting
Adds a "scanning" animation to the textarea on submit.

Screen.Recording.2025-10-17.at.17.35.53.mov

johnstcn added2 commits

October 17, 2025 14:40

chore(site): make PromptTextarea read-only when submitting

e059494

add animation to text area on submit

21fd3b9

johnstcn requested a review fromBrunoQuaresma

October 17, 2025 14:42

johnstcn self-assigned this

Oct 17, 2025

Copy link

Contributor

BrunoQuaresma commentedOct 17, 2025

Could you share a quick screen recording showing how the changes look? It would also be great to add a Story for that change.

Copy link

MemberAuthor

johnstcn commentedOct 17, 2025

Could you share a quick screen recording showing how the changes look? It would also be great to add a Story for that change.

Added! I'll get to work on the storybook changes.

Copy link

Contributor

BrunoQuaresma commentedOct 17, 2025

I’m not sure about the cursor animation though. I think it has too much movement. Maybe double-check with a PM? 🤔

johnstcn added2 commits

October 17, 2025 17:20

update stories

f0a045e

fixup! add animation to text area on submit

29e222d

Copy link

MemberAuthor

johnstcn commentedOct 17, 2025

I’m not sure about the cursor animation though. I think it has too much movement. Maybe double-check with a PM? 🤔

I updated the animation to be a little less 'busy'.

johnstcn changed the title~~chore(site): make TaskPrompt PromptTextarea read-only when submitting~~feat(site): make TaskPrompt PromptTextarea read-only when submitting

Oct 17, 2025

johnstcn marked this pull request as ready for review

October 17, 2025 16:43

johnstcn requested review fromParkreiner andaslilac ascode owners

October 17, 2025 16:43

johnstcn requested review fromDanielleMaywood andmafredri and removed request forParkreiner andaslilac

October 17, 2025 16:43

Copy link

Contributor

BrunoQuaresma commentedOct 17, 2025

Just one more thing: we’re using Tailwind CSS now, so defining styles like that is an anti-pattern. This might help:https://tailwindcss.com/docs/animation. Maybe Claude Code could help with this.

move animation to tailwind

e2295fa

Copy link

MemberAuthor

johnstcn commentedOct 17, 2025

Just one more thing: we’re using Tailwind CSS now, so defining styles like that is an anti-pattern. This might help:https://tailwindcss.com/docs/animation. Maybe Claude Code could help with this.

e2295fa (and Claude did)

DanielleMaywood approved these changes

Oct 17, 2025

View reviewed changes

Copy link

Contributor

DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sold on the cursor animation but we have a couple weeks until code-freeze so plenty of time to decide we do/don't like it

BrunoQuaresma approved these changes

Oct 17, 2025

View reviewed changes

johnstcn merged commitf6526b7 intomain

Oct 17, 2025

31 checks passed

johnstcn deleted the cj/task-textarea-readonly-submit branch

October 17, 2025 17:11

github-actionsbot locked and limited conversation to collaborators

Oct 17, 2025

Copy link

Contributor

michaelvp411 commentedOct 17, 2025

PR Summary

This PR improves the user experience of the TaskPrompt component by making the textarea read-only during submission.

Changes:

Modifiedsite/src/modules/tasks/TaskPrompt/TaskPrompt.tsx:60 to add areadOnly prop to the textarea
The textarea becomes read-only whenisSubmitting is true, preventing users from modifying the prompt while it's being processed

Impact:
This prevents potential issues where users might edit their prompt while it's being submitted, improving data integrity and providing clearer feedback about the submission state.