Why are we storing the secret?

TheFormatted stores the secret, so we were already storing the secret in this struct.

I added this field because the previous PR had 2 structs.

typeparsedSecretstruct {prefixstringsecretstring}typeAppSecretstruct {// Formatted contains the secret. This value is owned by the client, not the// server.  It is formatted to include the prefix.Formattedstring// Prefix is the ID of this secret owned by the server. When a client uses a// secret, this is the matching string to do a lookup on the hashed value.  We// cannot use the hashed value directly because the server does not store the// salt.Prefixstring// Hashed is the server stored hash(secret,salt,...). Used for verifying a// secret.Hashedstring}

TheparseFormattedSecret was inregistration.go. My refactor was to make 1 struct for theAppSecret and another forHashedAppSecret. I movedParseFormattedSecret next toGenerateSecret. I think we still need to workshop some better names to not conflate with other Secrets. Since it is in theoauth2provider package, I think that helps disambiguate it from say an APIKey secret

There is no new data being stored somewhere it was not previously.