- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: mount pprof and metrics to /api/v2/debug for admins#20353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It wasn't changed here, but the auth middleware comment above for debug says "ensure only owners can access". Is this statement still accurate consideringdebug_info:read?
Uh oh!
There was an error while loading.Please reload this page.
In essence the comment is true since only owners have that permission I believe. If you want I can change the comment to be more explicit though@mafredri |
Gotcha, if you don't mind it'd be nice to see the potential reduction of scope documented as well. PS. It looks like enterprise tests are unhappy. |
Decided to add back |
0652b18 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Adds the following debug routes for people with the
debug_info:readpermission:/api/v2/debug/pproffornet/http/pprof//profile/symbol/trace/*except/cmdline/api/v2/debug/metricsfor Prometheus metricsSee
net/http/pprof.init:https://cs.opensource.google/go/go/+/refs/tags/go1.25.3:src/net/http/pprof/pprof.go;l=95-105