- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(dogfood): revert unpin of containerd.io and pin docker-ce#20349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Ref: https://github.com/nestybox/sysbox/issues/879 | ||
| # We need to pin containerd to a specific version to avoid breaking | ||
| # Docker-in-Docker. | ||
| Package: containerd.io | ||
| Pin: version 1.7.23-1 | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. should we update the version of containerd as well? ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think we need to leave this version because ubuntu 20.04's latest version of containerd.io is 1.7.24, which is the problematic version that brought forward the original pinning of the package (seehttps://redirect.github.com/nestybox/sysbox/issues/879) | ||
| Pin-Priority: 1001 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,8 +4,12 @@ Pin: origin download.docker.com | ||
| Pin-Priority: 1 | ||
| # Docker Community Edition | ||
| # We need to pin docker-ce to a specific version because containerd is pinned | ||
| # to an older version. Newer major versions of docker-ce require a version of | ||
| # containerd.io greater than our pinned version. | ||
| Package: docker-ce | ||
| Pin: origin download.docker.com | ||
| Pin: version 5:27.* | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Docker 28 stable was released on October 8, which seems to roughly check out with when the dogfood action started failinghttps://docs.docker.com/engine/release-notes/28/ | ||
| Pin-Priority: 500 | ||
| # Docker command-line tool | ||
Uh oh!
There was an error while loading.Please reload this page.