- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(dogfood): revert unpin of containerd.io and pin docker-ce#20349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This reverts commit3eb993e.
This change pins the docker-ce major version for compatibility with thecontainerd.io package version we have pinned. Newer versions of docker-cehave a higher min version of containerd.io. While the underlying issuethat caused us to pin containerd.io is fixed in newer versions, we can'tyet remove the pin because some machines running dogfood are not yet updatedto a version of Linux that have a version of the fixed package (e.g.ubuntu 20.04).
b56e76a toc3d6076Compare| # containerd.io greater than our pinned version. | ||
| Package: docker-ce | ||
| Pin: origin download.docker.com | ||
| Pin: version 5:27.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Docker 28 stable was released on October 8, which seems to roughly check out with when the dogfood action started failinghttps://docs.docker.com/engine/release-notes/28/
| # We need to pin containerd to a specific version to avoid breaking | ||
| # Docker-in-Docker. | ||
| Package: containerd.io | ||
| Pin: version 1.7.23-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should we update the version of containerd as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we need to leave this version because ubuntu 20.04's latest version of containerd.io is 1.7.24, which is the problematic version that brought forward the original pinning of the package (seehttps://redirect.github.com/nestybox/sysbox/issues/879)
9f3b2cd intomainUh oh!
There was an error while loading.Please reload this page.
Previously we unpinned the containerd.io package since the dogfood template image build was failing due to docker-ce requiring a newer version of containerd.io. The build was fixed, but some dogfood machines experienced docker-in-docker problems again because their OS version didn't have the fixed containerd.io packages available.
This PR first reverts the unpinning of the containerd.io package, and pins the docker-ce major version for compatibility with the containerd.io package version we have pinned. Newer versions of docker-ce have a higher min version of containerd.io. While the underlying issue that caused us to pin containerd.io is fixed in newer versions, we can't yet remove the pin because some machines running dogfood are not yet updated to a version of Linux that have a version of the fixed package (e.g. ubuntu 20.04).