- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: improve template version select ux#20347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code looks good! Just had a few small comments
| >&{ | ||
| id?:string; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know this was technically here before, but why do we need this? TheTrigger type should already have an optionalid prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💯
| .toSorted((a,b)=>{ | ||
| return( | ||
| newDate(b.created_at).getTime()-newDate(a.created_at).getTime() | ||
| ); | ||
| }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we know if all of our customers can use this yet? I knowtoSorted broke a deployment for a customer in the past year or so because they hadn't upgraded their browser in a really long time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It started being supported by browsers at the beginning of 2023, so I think we’re good. We don’t have a strict rule for that, but using APIs that have been available for more than two years should be safe enough.
a6461ab intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Improvements:
Demo:
Screen.Recording.2025-10-16.at.12.48.01.mov
Closecoder/internal#1057