Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: improve options table reading#20341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/fix-options-table
Oct 17, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletionssite/src/pages/DeploymentSettingsPage/Option.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,26 +5,17 @@ import type { FC, HTMLAttributes, PropsWithChildren } from "react";
import { MONOSPACE_FONT_FAMILY } from "theme/constants";

export const OptionName: FC<PropsWithChildren> = ({ children }) => {
return <span css={{ display: "block" }}>{children}</span>;
};

export const OptionDescription: FC<PropsWithChildren> = ({ children }) => {
const theme = useTheme();

return (
<span
css={{
display: "block",
color: theme.palette.text.secondary,
fontSize: 14,
marginTop: 4,
}}
>
<span className="block text-sm font-medium text-content-primary">
{children}
</span>
);
};

export const OptionDescription: FC<PropsWithChildren> = ({ children }) => {
return <span className="text-sm font-normal">{children}</span>;
};

interface OptionValueProps {
children?: boolean | number | string | string[] | Record<string, boolean>;
}
Expand Down
25 changes: 2 additions & 23 deletionssite/src/pages/DeploymentSettingsPage/OptionsTable.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
import { css } from "@emotion/react";
import type { SerpentOption } from "api/typesGenerated";
import {
Table,
Expand DownExpand Up@@ -29,20 +28,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {
}

return (
<Table
className="options-table"
css={css`
& td {
padding-top: 24px;
padding-bottom: 24px;
}

& td:last-child,
& th:last-child {
padding-left: 32px;
}
`}
>
<Table className="options-table">
<TableHeader>
<TableRow>
<TableHead className="w-1/2">Option</TableHead>
Expand All@@ -56,14 +42,7 @@ const OptionsTable: FC<OptionsTableProps> = ({ options, additionalValues }) => {
<TableCell>
<OptionName>{option.name}</OptionName>
<OptionDescription>{option.description}</OptionDescription>
<div
css={{
marginTop: 24,
display: "flex",
flexWrap: "wrap",
gap: 8,
}}
>
<div className="pt-2 flex flex-wrap gap-2">
{option.flag && (
<OptionConfig isSource={option.value_source === "flag"}>
<OptionConfigFlag>CLI</OptionConfigFlag>
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp