Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: improve options table reading#20341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/fix-options-table
Oct 17, 2025
Merged

Conversation

@BrunoQuaresma
Copy link
Contributor

From@chrifro

  • text-sm regular for the body text (24px line height)
  • text-sm bold and white font for the headline

Before:

Screenshot 2025-10-16 at 10 08 19

After:

Screenshot 2025-10-16 at 10 10 27

Copy link
Contributor

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes look good overall. I guess I'm just a little concerned that the CSP text might be a bit cramped right now

@aslilac
Copy link
Member

the CSP text might be a bit cramped right now

yeah, like maybe that should be in a help tooltip or something

@BrunoQuaresma
Copy link
ContributorAuthor

I agree that the CSP text is quite long, but I’m not sure I’d want to add another element like a tooltip to handle that 🤔 Maybe we could just make the text shorter instead. What do you think,@matifali?

@BrunoQuaresmaBrunoQuaresma merged commit838fbc1 intomainOct 17, 2025
50 of 52 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-options-table branchOctober 17, 2025 12:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 17, 2025
@matifali
Copy link
Member

Post-merge approval ✅ . No strong opinions on refactoring the text. Let's think about the descriptions separately. The scope here was styling, which is addressed.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@matifalimatifaliAwaiting requested review from matifali

@chrifrochrifroAwaiting requested review from chrifro

@aslilacaslilacAwaiting requested review from aslilac

1 more reviewer

@ParkreinerParkreinerParkreiner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrunoQuaresma@aslilac@matifali@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp