- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: improve options table reading#20341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changes look good overall. I guess I'm just a little concerned that the CSP text might be a bit cramped right now
yeah, like maybe that should be in a help tooltip or something |
I agree that the CSP text is quite long, but I’m not sure I’d want to add another element like a tooltip to handle that 🤔 Maybe we could just make the text shorter instead. What do you think,@matifali? |
838fbc1 intomainUh oh!
There was an error while loading.Please reload this page.
Post-merge approval ✅ . No strong opinions on refactoring the text. Let's think about the descriptions separately. The scope here was styling, which is addressed. |
From@chrifro
Before:
After: