- Notifications
You must be signed in to change notification settings - Fork1.1k
chore(coderd): introduce TaskAppID and deprecate AITaskSidebarAppID#20336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -635,9 +635,9 @@ func (api *API) taskDelete(rw http.ResponseWriter, r *http.Request) { | ||
| // @Router /api/experimental/tasks/{user}/{task}/send [post] | ||
| // | ||
| // EXPERIMENTAL: This endpoint is experimental and not guaranteed to be stable. | ||
| // taskSend submits task input to thetask app by dialing the agent | ||
| // directly over the tailnet. We enforce ApplicationConnect RBAC on the | ||
| // workspace and validate thetask app health. | ||
| func (api *API) taskSend(rw http.ResponseWriter, r *http.Request) { | ||
| ctx := r.Context() | ||
| task := httpmw.TaskParam(r) | ||
| @@ -709,7 +709,7 @@ func (api *API) taskSend(rw http.ResponseWriter, r *http.Request) { | ||
| // | ||
| // EXPERIMENTAL: This endpoint is experimental and not guaranteed to be stable. | ||
| // taskLogs reads task output by dialing the agent directly over the tailnet. | ||
| // We enforce ApplicationConnect RBAC on the workspace and validate thetask app health. | ||
| func (api *API) taskLogs(rw http.ResponseWriter, r *http.Request) { | ||
| ctx := r.Context() | ||
| task := httpmw.TaskParam(r) | ||
| @@ -767,7 +767,7 @@ func (api *API) taskLogs(rw http.ResponseWriter, r *http.Request) { | ||
| // | ||
| // - Fetch the task workspace | ||
| // - Authorize ApplicationConnect on the workspace | ||
| // - Validate the AI task andtask app health | ||
| // - Dial the agent and construct an HTTP client to the apps loopback URL | ||
| // | ||
| // The provided callback receives the context, an HTTP client that dials via the | ||
| @@ -832,7 +832,7 @@ func (api *API) authAndDoWithTaskAppClient( | ||
| appURL := app.Url.String | ||
| if appURL == "" { | ||
| return httperror.NewResponseError(http.StatusInternalServerError, codersdk.Response{ | ||
| Message: "Task app URL is not configured.", | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Could this be enforced provider-side? 🤔 It's unfortunate to let it be a runtime error that basically turns the task defunct 😅. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I'm not sure if you can do cross-resource validation in Terraform, and you define the Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Then validation on provisioner side would perhaps be an option. ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. That makes sense to me | ||
| }) | ||
| } | ||
| parsedURL, err := url.Parse(appURL) | ||
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.