- Notifications
You must be signed in to change notification settings - Fork1.1k
chore(coderd): introduce TaskAppID and deprecate AITaskSidebarAppID#20336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore(coderd): introduce TaskAppID and deprecate AITaskSidebarAppID#20336
Uh oh!
There was an error while loading.Please reload this page.
Conversation
37589a9 to0b96862CompareAs we're moving away from the SidebarAppID nomenclature, this PRintroduces a new `TaskAppID` field to `codersdk.WorkspaceBuild` anddeprecates the `AITaskSidebarAppID` field. They both contain the samevalue.
0b96862 tob62e70bComparejohnstcn commentedOct 21, 2025
Can this wait until@mafredri 's stack goes in? |
DanielleMaywood commentedOct 21, 2025
@johnstcn Yep |
aslilac left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
frontend changes are all small and obvious enough :)
| ifappURL=="" { | ||
| returnhttperror.NewResponseError(http.StatusInternalServerError, codersdk.Response{ | ||
| Message:"Tasksidebarapp URL is not configured.", | ||
| Message:"Task app URL is not configured.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could this be enforced provider-side? 🤔 It's unfortunate to let it be a runtime error that basically turns the task defunct 😅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if you can do cross-resource validation in Terraform, and you define theurl in theworkspace_app resource :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Then validation on provisioner side would perhaps be an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That makes sense to me
e60112e intomainUh oh!
There was an error while loading.Please reload this page.
As we're moving away from the SidebarAppID nomenclature, this PR introduces a new
TaskAppIDfield tocodersdk.WorkspaceBuildand deprecates theAITaskSidebarAppIDfield. They both contain the same value.