- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(coderd): prevent task working notification for first app status#20313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Separately (likely separate PR), I wonder if we should actually notify on "completed" and "failed" states? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 🤖
According to yesterday's L&L I got the impression that that would be the idea 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't necessarily mind this change, but keep in mind it could take many minutes before the workspace is up and running, the user may be interested in that the work has actually started so they know to take a look at what's happening.
ade3fce intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Disclaimer: Claude did all of this, reviewed and committed by me.
I find the "task is working" notification straight after creation to be unnecessary.
Added logic to skip the notification if the first app status is "working".