- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: avoid connection logging crashes in agent [2.25]#20309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Ignore errors when reporting a connection from the server, just logthem instead- Translate connection log IP `localhost` to `127.0.0.1` on both theserver and the agent- Temporary fix: convert invalid IPs to `127.0.0.1` since the databaseforbids NULLRelates to#20194(cherry picked from commit03440f6)
Emyrk approved these changesOct 15, 2025
MemberAuthor
deansheather commentedOct 15, 2025
A CLI SSH test fails but I think that's just a 2.25 branch rot issue, not an issue with my code. All tests pass locally |
7db1675 intorelease/2.25 30 of 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
For release 2.25
localhostto127.0.0.1on both the server and the agent127.0.0.1since the database forbids NULLRelates to#20194
(cherry picked from commit03440f6)