Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: avoid deadlock race writing to a disconnected mapper#20303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/internal-1045-mapper-race
Oct 15, 2025

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedOct 15, 2025
edited
Loading

fixescoder/internal#1045

Fixes a race condition in our PG Coordinator when a peer disconnects. We issue database queries to find the peer mappings (node structures for each peer connected via a tunnel), and then send these to the "mapper" that generates diffs and eventually writes the update to the websocket.

Before this change we erroneously used the querier's context for this update, which has the same lifetime as the coordinator itself. If the peer has disconnected, the mapper might not be reading from its channel, and this causes a deadlock in a querier worker. This also prevents us from doing any more work on the peer.

I also added some more debug logging that would have been helpful when tracking this down.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewOctober 15, 2025 11:31
@spikecurtisspikecurtis merged commit05b037b intomainOct 15, 2025
37 checks passed
@spikecurtisspikecurtis deleted the spike/internal-1045-mapper-race branchOctober 15, 2025 11:56
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flake: TestPGCoordinatorSingle_AgentWithClient - timeout updating node for reconnection (PostgreSQL 17)

3 participants

@spikecurtis@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp