Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: keep button in loading state after start request is made#20294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/fix-starting
Oct 15, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletionssite/src/pages/TaskPage/TaskPage.stories.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -320,6 +320,60 @@ export const ActivePreview: Story = {
},
};

export const WorkspaceStarting: Story = {
decorators: [withGlobalSnackbar],
beforeEach: () => {
spyOn(API, "startWorkspace").mockResolvedValue(
MockStartingWorkspace.latest_build,
);
},
parameters: {
reactRouter: reactRouterParameters({
location: {
pathParams: {
username: MockStoppedWorkspace.owner_name,
workspace: MockStoppedWorkspace.name,
},
},
routing: {
path: "/tasks/:username/:workspace",
},
}),
queries: [
{
key: [
"tasks",
MockStoppedWorkspace.owner_name,
MockStoppedWorkspace.name,
],
data: {
prompt: "Create competitors page",
workspace: MockStoppedWorkspace,
},
},
{
key: ["workspace", MockStoppedWorkspace.id, "parameters"],
data: {
templateVersionRichParameters: [],
buildParameters: [],
},
},
],
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);

const startButton = await canvas.findByText("Start workspace");
expect(startButton).toBeInTheDocument();

await userEvent.click(startButton);

await waitFor(async () => {
expect(API.startWorkspace).toBeCalled();
});
},
};

export const WorkspaceStartFailure: Story = {
decorators: [withGlobalSnackbar],
beforeEach: () => {
Expand Down
13 changes: 9 additions & 4 deletionssite/src/pages/TaskPage/TaskPage.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ import { displayError } from "components/GlobalSnackbar/utils";
import { Loader } from "components/Loader/Loader";
import { Margins } from "components/Margins/Margins";
import { ScrollArea } from "components/ScrollArea/ScrollArea";
import { Spinner } from "components/Spinner/Spinner";
import { useWorkspaceBuildLogs } from "hooks/useWorkspaceBuildLogs";
import { ArrowLeftIcon, RotateCcwIcon } from "lucide-react";
import { AgentLogs } from "modules/resources/AgentLogs/AgentLogs";
Expand DownExpand Up@@ -206,6 +207,11 @@ const WorkspaceNotRunning: FC<WorkspaceNotRunningProps> = ({ task }) => {
},
});

// After requesting a workspace start, it may take a while to become ready.
// Show a loading state in the meantime.
const isWaitingForStart =
mutateStartWorkspace.isPending || mutateStartWorkspace.isSuccess;

const apiError = isApiError(mutateStartWorkspace.error)
? mutateStartWorkspace.error
: undefined;
Expand All@@ -223,16 +229,15 @@ const WorkspaceNotRunning: FC<WorkspaceNotRunningProps> = ({ task }) => {
<div className="flex flex-row mt-4 gap-4">
<Button
size="sm"
disabled={mutateStartWorkspace.isPending}
disabled={isWaitingForStart}
onClick={() => {
mutateStartWorkspace.mutate({
buildParameters: parameters?.buildParameters,
});
}}
>
{mutateStartWorkspace.isPending
? "Starting workspace..."
: "Start workspace"}
<Spinner loading={isWaitingForStart} />
Start workspace
</Button>
</div>
</div>
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp