- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(coderd/database): add ListTasks query#20282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
e901f8d to7b6e819Compare7b6e819 to4c1b0b2CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
one non-blocking and one slightly blocking question
coderd/database/dbauthz/dbauthz.go Outdated
| } | ||
| func (q*querier)ListTasks(ctx context.Context,arg database.ListTasksParams) ([]database.Task,error) { | ||
| // TODO(Cian): replace this with a sql filter for improved performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
non-blocking: should an issue be created for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also non-blocking, this type of filter blocks pagination. But that's not critical yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will file a follow-up issue (EDIT:coder/internal#1061)
Uh oh!
There was an error while loading.Please reload this page.
coderd/database/dbauthz/dbauthz.go Outdated
| } | ||
| func (q*querier)ListTasks(ctx context.Context,arg database.ListTasksParams) ([]database.Task,error) { | ||
| // TODO(Cian): replace this with a sql filter for improved performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also non-blocking, this type of filter blocks pagination. But that's not critical yet.
Uh oh!
There was an error while loading.Please reload this page.
9f22937 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Relates tocoder/internal#981
Stack: