- Notifications
You must be signed in to change notification settings - Fork1k
refactor: migrate CopyableValue from MUI to Radix UI#20261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jaaydenh wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+36 −24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Replace MUI Tooltip with Radix Tooltip components and migrate Emotion CSSto Tailwind utility classes. This is part of the ongoing effort tostandardize on Radix UI/shadcn components and Tailwind CSS.Changes:- Replace @mui/material/Tooltip with components/Tooltip/Tooltip (Radix)- Remove unused PopperProps (not used anywhere in codebase)- Rename placement prop to side to match Radix API- Replace Emotion css={{ cursor: "pointer" }} with Tailwind cursor-pointer class- Update single call site in IconsPage.tsx (placement → side)- Wrap in TooltipProvider as required by RadixTechnical details:- Radix uses Provider/Tooltip/Trigger/Content pattern (more verbose but flexible)- Maintained backward compatibility for all other call sites (6 files)- No functional changes to component behavior🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Migrates the
CopyableValuecomponent from Material-UI Tooltip to Radix UI Tooltip.Changes
CopyableValue Component
PopperProps(never used in any call site)placement→side(Radix naming convention)Updated Call Sites
placement="bottom"toside="bottom"(only call site using positioning prop)Migration Details
Before (MUI + Emotion):
After (Radix + Tailwind):
Minimal API surface change:
placementprop renamed toside(only affects 1 call site - already updated)PopperPropsremoved (was never used)