Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: migrate TermsOfServiceLink from MUI to shadcn/ui#20260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 3 commits intomainfromjaaydenh/refactor-terms-of-service
Oct 15, 2025

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedOct 12, 2025
edited
Loading

Summary

Migrate theTermsOfServiceLink component from MUI to shadcn/ui

Changes

  • Replaced@mui/material/Link with the customLink component fromcomponents/Link/Link (shadcn/ui)
  • Migrated Emotioncss prop to Tailwind utility classes
  • Preserved external link icon functionality (automatically provided by shadcn Link component)

🤖 Generated withClaude Code

Replace MUI Link with custom Link component from shadcn/ui and migrateEmotion CSS to Tailwind utility classes. This is part of the ongoingeffort to standardize on shadcn/ui components and Tailwind CSS.Changes:- Replace @mui/material/Link with components/Link/Link- Remove Emotion css prop in favor of Tailwind classes- Maintain visual consistency with pt-3, text-base, font-medium- Keep external link icon from shadcn Link component- No functional changes to component behavior🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
rel="noreferrer"
>
Terms of Service&nbsp;
<SquareArrowOutUpRightIconclassName="size-icon-xs"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why get rid of the arrow? it's to indicate it'll open in a new tab

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The component already has SquareArrowOutUpRightIcon inside it

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ah, I didn't realize the icon would come from the new component

@jaaydenhjaaydenh merged commit3699ff6 intomainOct 15, 2025
26 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/refactor-terms-of-service branchOctober 15, 2025 11:16
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

@buenos-nachosbuenos-nachosAwaiting requested review from buenos-nachos

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaaydenh@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp