- Notifications
You must be signed in to change notification settings - Fork1.1k
refactor: migrate TermsOfServiceLink from MUI to shadcn/ui#20260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Replace MUI Link with custom Link component from shadcn/ui and migrateEmotion CSS to Tailwind utility classes. This is part of the ongoingeffort to standardize on shadcn/ui components and Tailwind CSS.Changes:- Replace @mui/material/Link with components/Link/Link- Remove Emotion css prop in favor of Tailwind classes- Maintain visual consistency with pt-3, text-base, font-medium- Keep external link icon from shadcn Link component- No functional changes to component behavior🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
Uh oh!
There was an error while loading.Please reload this page.
| rel="noreferrer" | ||
| > | ||
| Terms of Service | ||
| <SquareArrowOutUpRightIconclassName="size-icon-xs"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why get rid of the arrow? it's to indicate it'll open in a new tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The component already has SquareArrowOutUpRightIcon inside it
aslilac left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ah, I didn't realize the icon would come from the new component
3699ff6 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Migrate the
TermsOfServiceLinkcomponent from MUI to shadcn/uiChanges
@mui/material/Linkwith the customLinkcomponent fromcomponents/Link/Link(shadcn/ui)cssprop to Tailwind utility classes🤖 Generated withClaude Code